-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unfix xarray, use nc-time-axis branch utime fix #620
Conversation
with xr.set_options(keep_attrs=True): | ||
bootstrapped_hind = resample_func(hind, iterations, resample_dim) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somehow attrs were dropped here now. why not before? unclear. fixed.
@@ -25,4 +25,5 @@ dependencies: | |||
- xskillscore>=0.0.18 | |||
- pip: | |||
- pytest-lazy-fixture | |||
- git+https://github.com/aulemahal/nc-time-axis.git@remove-utime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be reverted to nc-time-axis main once merged and released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 56 56
Lines 5047 5048 +1
=======================================
+ Hits 4694 4695 +1
Misses 353 353
Continue to review full report at Codecov.
|
Description
make installable and tests passing from source
Closes #618 #604
Type of change
Please delete options that are not relevant.
References
SciTools/nc-time-axis#59
SciTools/nc-time-axis#58