unfix xarray, use nc-time-axis branch utime fix #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronspring
commented
Jun 2, 2021
Comment on lines
+820
to
+821
| with xr.set_options(keep_attrs=True): | ||
| bootstrapped_hind = resample_func(hind, iterations, resample_dim) |
There was a problem hiding this comment.
somehow attrs were dropped here now. why not before? unclear. fixed.
aaronspring
commented
Jun 2, 2021
| @@ -25,4 +25,5 @@ dependencies: | |||
| - xskillscore>=0.0.18 | |||
| - pip: | |||
| - pytest-lazy-fixture | |||
| - git+https://github.com/aulemahal/nc-time-axis.git@remove-utime | |||
There was a problem hiding this comment.
should be reverted to nc-time-axis main once merged and released
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 56 56
Lines 5047 5048 +1
=======================================
+ Hits 4694 4695 +1
Misses 353 353
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make installable and tests passing from source
Closes #618 #604
Type of change
Please delete options that are not relevant.
References
SciTools/nc-time-axis#59
SciTools/nc-time-axis#58