Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Server: Add handling for custom middleware #200

Merged
merged 9 commits into from
Jul 10, 2019

Conversation

RandomByte
Copy link
Member

As per RFC 0005: SAP/ui5-tooling#151

@RandomByte RandomByte requested a review from Thodd June 18, 2019 13:32
@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from 9a60bb3 to b467f49 Compare June 18, 2019 15:04
@RandomByte
Copy link
Member Author

We should consider releasing this as a 2.0 since the index.js and the signatures of the middleware modules changed significantly.

@matz3
Copy link
Member

matz3 commented Jun 26, 2019

We could also deprecate the old middleware (exported via index.js) and map the argument names, right?
This way we wouldn't need to make a 2.0 and give consumers a chance to adopt their code in advance (although we never documented the exported middleware as public API).

@RandomByte
Copy link
Member Author

We could also deprecate the old middleware (exported via index.js) and map the argument names, right?

Done in latest change

Map to old signature to stay compatible with current, internal consumers
@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from be43277 to d2eb7b9 Compare July 2, 2019 14:12
@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from d2eb7b9 to 89b7b91 Compare July 2, 2019 14:17
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 93.529% when pulling 8859ab0 on server-middleware-extensibility into e726d68 on master.

@RandomByte RandomByte merged commit 037b3bc into master Jul 10, 2019
@RandomByte RandomByte deleted the server-middleware-extensibility branch July 10, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants