[FIX] Taskrunner: pass new taskutil options to determineRequiredDepen…

…dencies hook
SAP · Mar 30, 2023 · 94bcd99 · 94bcd99
1 parent 7ee6dde
commit 94bcd99
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/lib/build/TaskRunner.js b/lib/build/TaskRunner.js
@@ -302,13 +302,15 @@ class TaskRunner {
 					taskUtilInterface.getProject.bind(taskUtilInterface);
 				dependencyDeterminationParams.getDependencies =
 					taskUtilInterface.getDependencies.bind(taskUtilInterface);
-				dependencyDeterminationParams.options = {
-					projectName: project.getName(),
-					projectNamespace: project.getNamespace(),
-					configuration: taskDef.configuration,
-					taskName: newTaskName
-				};
 			}
+
+			dependencyDeterminationParams.options = {
+				projectName: project.getName(),
+				projectNamespace: project.getNamespace(),
+				configuration: taskDef.configuration,
+				taskName: newTaskName
+			};
+
 			requiredDependencies = await requiredDependenciesCallback(dependencyDeterminationParams);
 			if (!(requiredDependencies instanceof Set)) {
 				throw new Error(

diff --git a/test/lib/build/TaskRunner.js b/test/lib/build/TaskRunner.js
@@ -776,7 +776,13 @@ test("Custom task with legacy spec version and requiredDependenciesCallback", as
 
 	t.is(requiredDependenciesCallbackStub.callCount, 1, "requiredDependenciesCallback got called once");
 	t.deepEqual(requiredDependenciesCallbackStub.getCall(0).args[0], {
-		availableDependencies: new Set(["dep.a", "dep.b"])
+		availableDependencies: new Set(["dep.a", "dep.b"]),
+		options: {
+			projectName: "project.b",
+			projectNamespace: "project/b",
+			configuration: "configuration",
+			taskName: "myTask"
+		}
 	}, "requiredDependenciesCallback got called with expected arguments");
 
 	const createDependencyReaderStub = sinon.stub(taskRunner, "_createDependenciesReader").resolves("dependencies");