Skip to content

Commit

Permalink
[INTERNAL] Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
  • Loading branch information
matz3 and KlattG committed Mar 30, 2023
1 parent 7bdb47a commit 7ee6dde
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions lib/graph/Workspace.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class Workspace {
* @public
* @param {string} projectName Name of the project
* @returns {Promise<@ui5/project/graph/Module|undefined>}
* Module instance or <code>undefined</code> if none is found
* Module instance, or <code>undefined</code> if none is found
*/
async getModuleByProjectName(projectName) {
const {projectNameMap} = await this._getResolvedModules();
Expand All @@ -112,7 +112,7 @@ class Workspace {
* @public
* @param {string} nodeId Node ID of the module
* @returns {Promise<@ui5/project/graph/Module|undefined>}
* Module instance or <code>undefined</code> if none is found
* Module instance, or <code>undefined</code> if none is found
*/
async getModuleByNodeId(nodeId) {
const {moduleIdMap} = await this._getResolvedModules();
Expand Down
16 changes: 8 additions & 8 deletions lib/specifications/Specification.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ class Specification {

/* === Attributes === */
/**
* Get the ID of this specification.
* Gets the ID of this specification.
*
* <p><b>Note: </b>Only to be used in special occasions as it specific to the provider that was used and does
* <p><b>Note: </b>Only to be used for special occasions as it is specific to the provider that was used and does
* not necessarily represent something defined by the project.</p>
*
* For general purposes of a unique identifier use
Expand All @@ -175,7 +175,7 @@ class Specification {
}

/**
* Get the name of this specification. Represents a unique identifier.
* Gets the name of this specification. Represents a unique identifier.
*
* @public
* @returns {string} Specification name
Expand All @@ -185,7 +185,7 @@ class Specification {
}

/**
* Get the kind of this specification, for example <code>project</code> or <code>extension</code>
* Gets the kind of this specification, for example <code>project</code> or <code>extension</code>
*
* @public
* @returns {string} Specification kind
Expand All @@ -195,7 +195,7 @@ class Specification {
}

/**
* Get the type of this specification,
* Gets the type of this specification,
* for example <code>application</code> or <code>library</code> in case of projects,
* and <code>task</code> or <code>server-middleware</code> in case of extensions
*
Expand All @@ -217,7 +217,7 @@ class Specification {
}

/**
* Get the specification's generic version, as typically defined in a <code>package.json</code>
* Gets the specification's generic version, as typically defined in a <code>package.json</code>
*
* @public
* @returns {string} Project version
Expand All @@ -227,7 +227,7 @@ class Specification {
}

/**
* Get the specification's file system path. This might not be POSIX-style on some platforms
* Gets the specification's file system path. This might not be POSIX-style on some platforms
*
* @public
* @returns {string} Project root path
Expand All @@ -238,7 +238,7 @@ class Specification {

/* === Resource Access === */
/**
* Get a [ReaderCollection]{@link @ui5/fs/ReaderCollection} for the root directory of the specification.
* Gets a [ReaderCollection]{@link @ui5/fs/ReaderCollection} for the root directory of the specification.
* Resource readers always use POSIX-style
*
* @public
Expand Down

0 comments on commit 7ee6dde

Please sign in to comment.