Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add config command #618

Merged
merged 15 commits into from
Apr 25, 2023
Merged

[FEATURE] Add config command #618

merged 15 commits into from
Apr 25, 2023

Commits on Apr 24, 2023

  1. Add .ui5rc configuration

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    35cdf3c View commit details
    Browse the repository at this point in the history

  2. Format the output

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    2b37979 View commit details
    Browse the repository at this point in the history

  3. Format output

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    740eceb View commit details
    Browse the repository at this point in the history

  4. Add tests

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    7bab8d8 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0af6e46 View commit details
    Browse the repository at this point in the history

  6. Update missing dependencies

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3f27832 View commit details
    Browse the repository at this point in the history

  7. Use Configuration from ui5-project 

    SAP/ui5-project#575
    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8a0ce41 View commit details
    Browse the repository at this point in the history

  8. snapshotEndpointUrl -> mavenSnapshotEndpointUrl

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    085535f View commit details
    Browse the repository at this point in the history

  9. Remove graceful-fs

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    a13f3e5 View commit details
    Browse the repository at this point in the history

  10. Fix lint issues

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c599a0e View commit details
    Browse the repository at this point in the history

  11. consume @ui5-project->Configuration properly

    @d3xter666
    d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c5d78c7 View commit details
    Browse the repository at this point in the history

  12. cli/base: Update error messages 

    * No help is printed on yargs errors, so do not refer to it
  (also see #256)
* Only mention 'ui5 --help'
    @RandomByte @d3xter666
    RandomByte authored and d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1785172 View commit details
    Browse the repository at this point in the history

  13. cli/config: Update texts, fix edge cases, fix tests 

    * Fix 'ui5 set <key>' without value or empty string to unset
* Log everything to stderr, except machine parsable output like
  configuration values returned by 'ui5 list' and 'ui5 get <key>'
* Do not mention location of ui5rc in config commands. In the future we
  might have multiple locations and @ui5/project/config/Configuration
  would take care of deciding where to read what from. The CLI should
  not have that knowledge
* Move imports and variable definitions to handler in order to only
  execute them if the command is actually 'ui5 config'
* Tests now mock Configuration in order to not modify the actual
  configuration of the user running the tests
    @RandomByte @d3xter666
    RandomByte authored and d3xter666 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    22cd468 View commit details
    Browse the repository at this point in the history

  14. cli/config: Update 'set' command description

    @RandomByte
    RandomByte committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    19122b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. [INTERNAL] Apply suggestions from UA review 

    Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
    @RandomByte @KlattG
    RandomByte and KlattG committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    04fdf8d View commit details
    Browse the repository at this point in the history