[FEATURE] CLI: Improve error reporting #256
Merged
+213
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Code Coverage of new code in base middleware |
|
Nice 👍 |
Yargs errors (like 'Unkown argument') do not print the command help anymore but a hint to use 'ui5 --help'. Exceptions are now formatted in a nice way. On default log level only the error message is printed out and a hint to use the --verbose flag for details. On verbose log level, the stack trace is printed as well and a hint featuring the URL to open a new issue for the UI5 Tooling module that is most likely at fault based on an analysis of the first line of the stack trace.
RandomByte
force-pushed
the
improve-error-reporting
branch
from
4b9176b
to
347e1f1
Compare
|
Code covered now 👍 |
matz3
approved these changes
Oct 14, 2019
RandomByte
added a commit
that referenced
this pull request
Apr 21, 2023
* No help is printed on yargs errors, so do not refer to it (also see #256) * Only mention 'ui5 --help'
d3xter666
pushed a commit
that referenced
this pull request
Apr 24, 2023
* No help is printed on yargs errors, so do not refer to it (also see #256) * Only mention 'ui5 --help'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yargs errors (like 'Unkown argument') do not print the command help
anymore but a hint to use 'ui5 --help'.
Exceptions are now formatted in a nice way.
On default log level only the error message is printed out and a hint to
use the --verbose flag for details.
On verbose log level, the stack trace is printed as well and a hint
featuring the URL to open a new issue for the UI5 Tooling module that
is most likely at fault based on an analysis of the first line of the
stack trace.
Examples
Exception on default log level:
Exception on verbose log level:
Unknown argument:
Note
The new dependency
chalkis already a dependency ofupdate-notifierThis depends on SAP/ui5-logger#136