Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SapUiDefine call should not fail when there's no factory function #491

Merged
merged 4 commits into from
Aug 11, 2020
Merged

[FIX] SapUiDefine call should not fail when there's no factory function #491

merged 4 commits into from
Aug 11, 2020

Commits on Aug 8, 2020

  1. [FIX] SapUiDefine call should not fail when there's no factory function 

    Other existing implementations, like the one in ui5-migration tooling,
had already been fixed in similar ways.
    @codeworrior
    codeworrior committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    94f1521 View commit details
    Browse the repository at this point in the history

  2. Also import 'isBoolean' in SapUiDefineCall

    @codeworrior
    codeworrior committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    60c0193 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate test (copy&paste error)

    @codeworrior
    codeworrior committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    54ed99e View commit details
    Browse the repository at this point in the history

  4. Improve coverage for ASTUtils

    @codeworrior
    codeworrior committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    6cf21d4 View commit details
    Browse the repository at this point in the history