Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SapUiDefine call should not fail when there's no factory function #491

Merged
merged 4 commits into from
Aug 11, 2020
Merged

[FIX] SapUiDefine call should not fail when there's no factory function #491

merged 4 commits into from
Aug 11, 2020

Conversation

codeworrior
Copy link
Member

Other existing implementations, like the one in ui5-migration tooling,
had already been fixed in similar ways.

@codeworrior
[FIX] SapUiDefine call should not fail when there's no factory function
94f1521 
Other existing implementations, like the one in ui5-migration tooling,
had already been fixed in similar ways.
@coveralls
Copy link

coveralls commented Aug 8, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 91.537% when pulling 6cf21d4 on fix-SapUiDefineCall into e7d4431 on master.

@codeworrior codeworrior mentioned this pull request Aug 8, 2020
Merged
@codeworrior codeworrior merged commit 25c6a3c into master Aug 11, 2020
@codeworrior codeworrior deleted the fix-SapUiDefineCall branch August 11, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeworrior @coveralls @RandomByte