Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Update JSDoc to 3.6.3 #356

Merged
merged 1 commit into from
Oct 22, 2019
Merged

[INTERNAL] Update JSDoc to 3.6.3 #356

merged 1 commit into from
Oct 22, 2019
+85 −43

Conversation

RandomByte
Copy link
Member

Re-open version range in package.json to patches like grunt-jsdoc is
doing:
https://github.com/krampstudio/grunt-jsdoc/blob/7b4c6eb9db6ae207b18f1fdf37bc71d8c98c76da/package.json#L44

Minor updates tend to break the UI5 JSDoc plugin.

@RandomByte
[INTERNAL] Update JSDoc to 3.6.3
9ea64e2 
Re-open version range in package.json to patches like grunt-jsdoc is
doing:
https://github.com/krampstudio/grunt-jsdoc/blob/7b4c6eb9db6ae207b18f1fdf37bc71d8c98c76da/package.json#L44

Minor updates tend to break the UI5 JSDoc plugin.
@RandomByte RandomByte mentioned this pull request Oct 21, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.178% when pulling 9ea64e2 on jsdoc-3.6.3 into 78e2a22 on master.

codeworrior
codeworrior approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For patch level changes, we can give it a try.

matz3
matz3 reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this update worth mentioning in the changelog?

@RandomByte
Copy link
Member Author

Well we already mention it here: 78e2a22 😅

@RandomByte RandomByte merged commit 829134b into master Oct 22, 2019
@RandomByte RandomByte deleted the jsdoc-3.6.3 branch October 22, 2019 14:46
@matz3
Copy link
Member

matz3 commented Oct 22, 2019

Ah I've missed that 👍

matz3 added a commit that referenced this pull request Oct 24, 2019
@matz3
[INTERNAL] jsdoc: Adopt version range to micro releases
ee98f13 
Follow-up of #356
@matz3 matz3 mentioned this pull request Oct 24, 2019
Merged
matz3 added a commit that referenced this pull request Oct 24, 2019
@matz3
[FIX] jsdoc: Adopt version range to micro releases (#357)
619b959 
Follow-up of #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@codeworrior codeworrior codeworrior approved these changes

@tobiasso85 tobiasso85 Awaiting requested review from tobiasso85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomByte @coveralls @matz3 @codeworrior