[FIX] Update JSDoc to 3.6.3 (#346)

* Node 12 now supported * Update SDK scripts with versions from other repositories * Skip undefined inherited symbols introduced with JSDoc 3.6.3 * Remove CLI execution part from SDK scripts
SAP · Oct 21, 2019 · 78e2a22 · 78e2a22
1 parent 1742b9c
commit 78e2a22
Show file tree

Hide file tree

Showing 8 changed files with 570 additions and 342 deletions.
diff --git a/lib/processors/jsdoc/apiIndexGenerator.js b/lib/processors/jsdoc/apiIndexGenerator.js
@@ -1,5 +1,5 @@
 const resourceFactory = require("@ui5/fs").resourceFactory;
-const createIndex = require("./lib/create-api-index");
+const createIndex = require("./lib/createIndexFiles");
 
 /**
  * Compiles API index resources from all <code>api.json</code> resources available in the given test resources directory

diff --git a/lib/processors/jsdoc/lib/create-api-index.js → lib/processors/jsdoc/lib/createIndexFiles.js b/lib/processors/jsdoc/lib/create-api-index.js → lib/processors/jsdoc/lib/createIndexFiles.js
@@ -24,7 +24,7 @@ const log = (function() {
 	}
 }());
 
-function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetFileDeprecated, targetFileExperimental, targetFileSince, options) {
+function createIndexFiles(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetFileDeprecated, targetFileExperimental, targetFileSince, options) {
 	const fs = options && options.fs || require("fs");
 	const returnOutputFiles = options && !!options.returnOutputFiles;
 
@@ -269,6 +269,7 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
 						displayName: sPart,
 						lib: oSymbol.lib,
 						kind: "namespace",
+						visibility: "public", // Virtual namespace are always public
 						bIsDeprecated: false // Virtual namespace can't be deprecated
 					});
 				}
@@ -329,8 +330,8 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
 		function cleanTree (oSymbol) {
 			delete oSymbol.treeName;
 			delete oSymbol.parent;
-			if (oSymbol.children) {
-				oSymbol.children.forEach(o => cleanTree(o));
+			if (oSymbol.nodes) {
+				oSymbol.nodes.forEach(o => cleanTree(o));
 			}
 		}
 		aTree.forEach(o => cleanTree(o));
@@ -449,4 +450,4 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
 
 }
 
-module.exports = process;
+module.exports = createIndexFiles;