Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2]: ENG-2806 Ensure Integration Form Validation Works #1219

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Apr 17, 2023

Describe your changes and why you are making these changes

This PR ensures that integrations form validation works properly after changing form input empty state from null to empty string (this was needed to fix a console error message).

Depends on: #1218

Related issue number (if any)

ENG-2806

Loom demo (if any)

https://www.loom.com/share/eb58d20deee64922b83841fcb6bf7362

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@@ -223,6 +223,20 @@ export const AthenaDialog: React.FC<Props> = ({
);
};

// TODO: Figure out How we should validate the input forms for Athena
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: @agiron123 address comments from slack here.

Andre Giron added 3 commits April 17, 2023 11:30
…ng empty form values as null and not empty string as recommended by browser error message.
@agiron123 agiron123 force-pushed the eng-2806-m2-ensure-integration-form-validation branch from 6e3e497 to 2adcef8 Compare April 17, 2023 18:31
@agiron123 agiron123 requested a review from likawind April 17, 2023 18:51
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, will these be covered by react class and react hook form later?

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 17, 2023
@agiron123
Copy link
Contributor Author

Great, will these be covered by react class and react hook form later?

@likawind Yes, validations here will go through react-hook form later. However, I do expect them to remain mostly the same. Maybe a small amount of syntactic sugar that react-hook-form provides, but not too many changes in terms of how we validate.

@agiron123 agiron123 merged commit 66e8f93 into main Apr 17, 2023
@agiron123 agiron123 deleted the eng-2806-m2-ensure-integration-form-validation branch April 17, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants