[1/2]: ENG-2805: Integration Form Empty State Console Error Fixes #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng empty form values as null and not empty string as recommended by browser error message.
agiron123
added
the
skip_integration_test
likawind
approved these changes
Apr 15, 2023
agiron123
commented
Apr 17, 2023
src/ui/common/src/components/integrations/dialogs/slackDialog.tsx
Outdated
Show resolved
Hide resolved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR resolves error messages that appeared in integrations dialogs related to passing in null when the input's state was empty.
To resolve this, we use empty strings for empty input values. This change impacts some of the validation functions in our integrations, which will be resolved in another PR.
Related issue number (if any)
ENG-2805
Loom demo (if any)
https://linear.app/aqueducthq/issue/ENG-2805/fix-console-errors-on-existing-integrations-dialogs
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)