-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Stop Firefox announcement overflowing viewport #10503
Conversation
Fixes an issue where long announcement messages caused the right-hand sidebar to and associated icons to be pushed outside the viewport due to how non-wrapping whitespace was interacting with flex layout. As a tradeoff, this commit causes overflowing text to no longer be displayed with a nice ellipsis in other browsers, simply cutting it short instead.
@brendangadd thank you for your contribution 😄 but I don't think we can get rid of the ellipsis, we need to find another way. If you need help text me on open.rocket.chat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't lose the ellipsis on announcements
Announcment text is now wrapped in a `<p>` element which allows an extra flex container to control text overflow for long announcements. With this addition, announcements no longer make the right sidebar and its associated icons innaccessible by pushing them out of the viewport. A previous commit accomplished this by allowing whitespace to wrap, which caused overflowing text to clip rather than receive an ellipsis. This commit restores the ellipsis.
@karlprieb: Alright, I found a way to preserve the ellipsis. Tested in Firefox and Chromium. |
@karlprieb: Newbie question... am I supposed to "Update branch" and merge, or do you guys with write permission take care of that? |
Hey @brendangadd! @rodrigok will merge that! |
* develop: (79 commits) fixed problems with margin negative (RocketChat#10558) Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574) Added target="_blank" to homepage and support link. (RocketChat#10575) [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503) [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550) Fix inconsistent response of settings.oauth endpoint (RocketChat#10553) Regression: Remove added mentions on quote/reply (RocketChat#10571) Fix the attachments and fields incorrectly failing on validation (RocketChat#10573) Deps update (RocketChat#10549) Map consumerKey to clientId (fix Twitter) (RocketChat#10560) Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555) Fix issues with the rooms and apps (RocketChat#10559) Fix regression with announcement bar being displayed without content (RocketChat#10554) LingoHub based on develop (RocketChat#10545) Regression: Revert announcement structure (RocketChat#10544) Regression: Upload was not working (RocketChat#10543) Remove duplicated key from en.i18n.json Included missing lib (RocketChat#10532) dependencies update [NEW] Option to mute group mentions (@ALL and @here) (RocketChat#10502) ... # Conflicts: # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-i18n/i18n/vi-VN.i18n.json # packages/rocketchat-ui-flextab/client/tabs/membersList.html # packages/rocketchat-ui-message/client/popup/messagePopupConfig.js # packages/rocketchat-ui-sidenav/client/sidebarHeader.js
…into goalify * 'goalify' of https://github.com/goalifyplus/Goalify.Chat: (80 commits) Update gitlab, npm package lock, include current server update script fixed problems with margin negative (RocketChat#10558) Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574) Added target="_blank" to homepage and support link. (RocketChat#10575) [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503) [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550) Fix inconsistent response of settings.oauth endpoint (RocketChat#10553) Regression: Remove added mentions on quote/reply (RocketChat#10571) Fix the attachments and fields incorrectly failing on validation (RocketChat#10573) Deps update (RocketChat#10549) Map consumerKey to clientId (fix Twitter) (RocketChat#10560) Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555) Fix issues with the rooms and apps (RocketChat#10559) Fix regression with announcement bar being displayed without content (RocketChat#10554) LingoHub based on develop (RocketChat#10545) Regression: Revert announcement structure (RocketChat#10544) Regression: Upload was not working (RocketChat#10543) Remove duplicated key from en.i18n.json Included missing lib (RocketChat#10532) dependencies update ...
* goalify: (104 commits) Regression: Various search provider fixes (RocketChat#10591) Supplement TOS and privacy policy texts for use within server instances Fix /api/v1/settings.oauth not sending needed info for SAML & CAS (RocketChat#10596) Fix the Apps and Livechats not getting along well with each other (RocketChat#10598) [FIX] Missing "Administration" menu for users with some administration permissions (RocketChat#10551) [FIX] Member list search with no results (RocketChat#10599) merge vi-VN and vi json Add and enhance translations Update gitlab, npm package lock, include current server update script Adds Visual Studio Code debugging configuration (RocketChat#10586) [FIX] Integrations with room data not having the usernames filled in (RocketChat#10576) fixed problems with margin negative (RocketChat#10558) Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574) Added target="_blank" to homepage and support link. (RocketChat#10575) [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503) [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550) Fix inconsistent response of settings.oauth endpoint (RocketChat#10553) Regression: Remove added mentions on quote/reply (RocketChat#10571) Fix the attachments and fields incorrectly failing on validation (RocketChat#10573) Deps update (RocketChat#10549) ...
Fixes an issue where long announcement messages caused the right-hand
sidebar to and associated icons to be pushed outside the viewport due
to how non-wrapping whitespace was interacting with flex layout.
As a tradeoff, this commit causes overflowing text to no longer be
displayed with a nice ellipsis in other browsers, simply cutting it
short instead.
Tested in Firefox 59, Chromium 65, and IE11.