Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Option to mute group mentions (@all and @here) #10502

Merged
merged 5 commits into from
Apr 21, 2018

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Apr 18, 2018

Closes #1654

This PR adds a new preference on the channel notification settings to mute @all and @here mention notifications.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10502 April 18, 2018 20:46 Inactive
@graywolf336
Copy link
Contributor

Is this a user preference? I am just thinking that there can be some channels, like say announcements, which admins of a server don't want people to turn off this type of notification...any ideas?

@Hudell
Copy link
Contributor Author

Hudell commented Apr 18, 2018

It's a user preference, per channel.

Allowing admins to disable this preference for certain channels would also be a nice feature to have, but I don't see it as a requirement.

@karlprieb
Copy link
Contributor

Maybe we should merge this PR and create another issue to work on this "improvement", what you guys think?

@graywolf336
Copy link
Contributor

Do we currently have an option for admins to disable notifications preferences for users?

@geekgonecrazy
Copy link
Contributor

@Hudell what do you think about calling it group mentions instead of generic? I think its a bit more meaningful.

I think this would be a great thing to have.

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10502 April 20, 2018 23:54 Inactive
ggazzo
ggazzo previously approved these changes Apr 20, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10502 April 20, 2018 23:56 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10502 April 21, 2018 00:21 Inactive
…ket.Chat.git; branch 'mute-generic-mentions' of github.com:RocketChat/Rocket.Chat into mute-generic-mentions
@ggazzo ggazzo changed the title [NEW] Option to mute generic mentions (@all and @here) [NEW] Option to mute group mentions (@all and @here) Apr 21, 2018
@rodrigok rodrigok added this to the 0.64.0 milestone Apr 21, 2018
@rodrigok rodrigok merged commit 27f312d into develop Apr 21, 2018
@rodrigok rodrigok deleted the mute-generic-mentions branch April 21, 2018 02:02
engelgabriel added a commit that referenced this pull request Apr 21, 2018
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Option to mute group mentions (@ALL and @here) (#10502)
  [NEW] GDPR - Right to access and Data Portability (#9906)
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request Apr 27, 2018
* develop: (79 commits)
  fixed problems with margin negative (RocketChat#10558)
  Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574)
  Added target="_blank" to homepage and support link. (RocketChat#10575)
  [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503)
  [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550)
  Fix inconsistent response of settings.oauth endpoint (RocketChat#10553)
  Regression: Remove added mentions on quote/reply (RocketChat#10571)
  Fix the attachments and fields incorrectly failing on validation (RocketChat#10573)
  Deps update (RocketChat#10549)
  Map consumerKey to clientId (fix Twitter) (RocketChat#10560)
  Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555)
  Fix issues with the rooms and apps (RocketChat#10559)
  Fix regression with announcement bar being displayed without content (RocketChat#10554)
  LingoHub based on develop (RocketChat#10545)
  Regression: Revert announcement structure (RocketChat#10544)
  Regression: Upload was not working (RocketChat#10543)
  Remove duplicated key from en.i18n.json
  Included missing lib (RocketChat#10532)
  dependencies update
  [NEW] Option to mute group mentions (@ALL and @here) (RocketChat#10502)
  ...

# Conflicts:
#	packages/rocketchat-i18n/i18n/en.i18n.json
#	packages/rocketchat-i18n/i18n/vi-VN.i18n.json
#	packages/rocketchat-ui-flextab/client/tabs/membersList.html
#	packages/rocketchat-ui-message/client/popup/messagePopupConfig.js
#	packages/rocketchat-ui-sidenav/client/sidebarHeader.js
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants