Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors with Rust 1.73.0 #996

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mtreinish
Copy link
Member

The recent Rust 1.73.0 release introduced some changes to clippy's behavior that are causing failures in CI (and correctly calling out issues in our code). This commit updates the rustworkx source to correct these failures.

The recent Rust 1.73.0 release introduced some changes to clippy's
behavior that are causing failures in CI (and correctly calling out
issues in our code). This commit updates the rustworkx source to correct
these failures.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6424269503

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.494%

Totals Coverage Status
Change from base Build 6399029505: 0.003%
Covered Lines: 15414
Relevant Lines: 15974

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanIsCoding IvanIsCoding merged commit 651409f into Qiskit:main Oct 5, 2023
25 checks passed
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Feb 20, 2024
@mtreinish mtreinish deleted the fix-clippy-1.73 branch February 20, 2024 19:45
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
The recent Rust 1.73.0 release introduced some changes to clippy's
behavior that are causing failures in CI (and correctly calling out
issues in our code). This commit updates the rustworkx source to correct
these failures.

(cherry picked from commit 651409f)
@mtreinish
Copy link
Member Author

@Mergifyio backport stable/0.14

Copy link
Contributor

mergify bot commented Feb 20, 2024

backport stable/0.14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 20, 2024
The recent Rust 1.73.0 release introduced some changes to clippy's
behavior that are causing failures in CI (and correctly calling out
issues in our code). This commit updates the rustworkx source to correct
these failures.

(cherry picked from commit 651409f)

# Conflicts:
#	src/score.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants