-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clear, clear_edges functions to PyGraph and PyDiGraph objects #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, I think we just need to add another test and it should be good to go
releasenotes/notes/add-clear-and-clear_edges-for-graphs-041b166aa541639c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-clear-and-clear_edges-for-graphs-041b166aa541639c.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-clear-and-clear_edges-for-graphs-041b166aa541639c.yaml
Outdated
Show resolved
Hide resolved
@IvanIsCoding Just put in a commit that adds graph reuse cases for both |
The CI failures you hit before were caused by the new release of rust that happened today: https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html I pushed up a separate PR to fix these build errors: #996 |
Copy that @mtreinish, I pushed those fixes on my end since the issue you reference seems to have been merged. |
Pull Request Test Coverage Report for Build 6426717105
💛 - Coveralls |
@mtreinish @IvanIsCoding Thank you for the help with my first PR! |
Congrats on your first contribution to rustworkx! |
Can now use
clear()
andclear_edges()
on any PyGraph or PyDiGraph object, fixes #984.clear()
: Clears all nodes and edges, updatesnode_removed
value totrue
clear_edges()
: Clears all edges, leaves nodes intact.