Only publish wheel for retworkx compat package #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the retworkx compat package publish job. The first issue is that the sdist for the retworkx package is not valid, we trigger the creation of the compat package by an env variable when calling setup.py/setuptools/builder/etc which triggers change the package name and other attributes. However if we create an sdist while setting the env variable this just bundles the setup.py and other source files in a tarball and when the sdist is installed rustworkx would be installed. So for the compat package we should only publish a pure python wheel that will have the actual compat shim. The other small change is switch the package to use python 3.10 instead of 3.7, which goes EoL in the near future.
Pull Request Test Coverage Report for Build 3588101381
💛 - Coveralls |
mtreinish
added
the
stable-backport-potential
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
This commit fixes the retworkx compat package publish job. The first issue is that the sdist for the retworkx package is not valid, we trigger the creation of the compat package by an env variable when calling setup.py/setuptools/builder/etc which triggers change the package name and other attributes. However if we create an sdist while setting the env variable this just bundles the setup.py and other source files in a tarball and when the sdist is installed rustworkx would be installed. So for the compat package we should only publish a pure python wheel that will have the actual compat shim. The other small change is switch the package to use python 3.10 instead of 3.7, which goes EoL in the near future. Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> (cherry picked from commit 100d0dc)
mergify bot
added a commit
that referenced
this pull request
Dec 1, 2022
This commit fixes the retworkx compat package publish job. The first issue is that the sdist for the retworkx package is not valid, we trigger the creation of the compat package by an env variable when calling setup.py/setuptools/builder/etc which triggers change the package name and other attributes. However if we create an sdist while setting the env variable this just bundles the setup.py and other source files in a tarball and when the sdist is installed rustworkx would be installed. So for the compat package we should only publish a pure python wheel that will have the actual compat shim. The other small change is switch the package to use python 3.10 instead of 3.7, which goes EoL in the near future. Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> (cherry picked from commit 100d0dc) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the retworkx compat package publish job. The first issue is that the sdist for the retworkx package is not valid, we trigger the creation of the compat package by an env variable when calling setup.py/setuptools/builder/etc which triggers change the package name and other attributes. However if we create an sdist while setting the env variable this just bundles the setup.py and other source files in a tarball and when the sdist is installed rustworkx would be installed. So for the compat package we should only publish a pure python wheel that will have the actual compat shim. The other small change is switch the package to use python 3.10 instead of 3.7, which goes EoL in the near future.