Skip to content

Commit

Permalink
Only publish wheel for retworkx compat package (#749)
Browse files Browse the repository at this point in the history
This commit fixes the retworkx compat package publish job. The first
issue is that the sdist for the retworkx package is not valid, we
trigger the creation of the compat package by an env variable when
calling setup.py/setuptools/builder/etc which triggers change the
package name and other attributes. However if we create an sdist while
setting the env variable this just bundles the setup.py and other source
files in a tarball and when the sdist is installed rustworkx would be
installed. So for the compat package we should only publish a pure
python wheel that will have the actual compat shim. The other small
change is switch the package to use python 3.10 instead of 3.7, which
goes EoL in the near future.

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
  • Loading branch information
mtreinish and IvanIsCoding committed Dec 1, 2022
1 parent 07af925 commit 100d0dc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,11 @@ jobs:
- uses: actions/setup-python@v2
name: Install Python
with:
python-version: '3.7'
python-version: '3.10'
- name: Install deps
run: pip install -U twine setuptools-rust
- name: Build sdist
run: python setup.py sdist bdist_wheel
run: python setup.py bdist_wheel
env:
RUSTWORKX_PKG_NAME: retworkx
- uses: actions/upload-artifact@v2
Expand Down

0 comments on commit 100d0dc

Please sign in to comment.