Fix duplicate key in IPA to RTGS phoneme mapping #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @BLKSerene! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-10-22 13:08:50 UTC |
|
Kudos, SonarCloud Quality Gate passed!
|
bact
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Following #851, this PR removes the duplicate key in IPA to RTGS phoneme mapping, according to discussions in #846.
What was wrong
Duplicate keys in Python dictionaries are meaningless and only create confusions.
How this fixes it
The first key-value mapping of the duplicate key is commented out.
Fixes #846 along with #851.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.