Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ISO 11940 duplicate keys #851

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fix ISO 11940 duplicate keys #851

merged 4 commits into from
Oct 19, 2023

Conversation

bact
Copy link
Member

@bact bact commented Oct 19, 2023 •
edited
Loading

Partially fix #846 as reported by @BLKSerene

@bact bact added the bug bugs in the library label Oct 19, 2023
@bact bact added this to the 4.1 milestone Oct 19, 2023
@bact bact self-assigned this Oct 19, 2023
@pep8speaks
Copy link

pep8speaks commented Oct 19, 2023 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-19 13:33:14 UTC

@bact @BLKSerene
Fix code indent
dbd2e66 
Co-authored-by: BLKSerene <blkserene@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bact bact added the hacktoberfest-accepted hacktoberfest accepted pull requests. label Oct 19, 2023
@bact bact merged commit b8a85b2 into dev Oct 19, 2023
10 of 18 checks passed
@bact bact mentioned this pull request Oct 19, 2023
Closed
@bact bact deleted the fix-iso-11940-dup-keys branch October 20, 2023 13:47
@BLKSerene BLKSerene mentioned this pull request Oct 22, 2023
Merged
2 tasks
@bact bact mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bact bact

Labels
bug bugs in the library hacktoberfest-accepted hacktoberfest accepted pull requests.
Projects
PyThaiNLP
  
Awaiting triage
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

bug: Duplicate key in dictionary
2 participants
@bact @pep8speaks