Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Git] Add of some jasmine tests #355

Closed
wants to merge 1 commit into from

Conversation

lgiraudel
Copy link
Contributor

Add of some jasmine tests to check the HTML output.

The tests can be executed with gulp test or automatically with gulp watch.

@KittyGiraudel
Copy link

Thanks bro.

@apfelbox
Copy link
Contributor

Thanks! I am currently working on a test environment, too, but want to make it a little bit more comfortable and automated, so that it is very easy to add new test / alter existing tests.

I will come back to this in the future - as soon as I have a working prototype.

*/
'commit_sha1': /^commit \w{40}$/m
};
}());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nicer to pass the global Prism variable here?

And add it as an argument for the anonymous function?
This way, you would have a fixed and static dependency on Prism.

@apfelbox
Copy link
Contributor

@lgiraudel if you split this PR in two (one with the git language changes and one with jasmine testing), I could merge the git one right away.

@LeaVerou
Copy link
Member

In general, please people, do not submit multiple changes on the same PR. It’s also in the readme:

Please try to err towards more smaller PRs rather than few huge PRs. If a PR includes changes I want to merge and changes I don't, handling it becomes difficult.

(Btw @apfelbox we need to change the readme to mention that contributors can also merge PRs, as it still says that merging PRs takes ages because it was written when only I could do it.)

@Golmote Golmote mentioned this pull request Dec 13, 2014
@TimothyGu
Copy link
Contributor

Is there a reason why you used Jasmine instead of Mocha? I don't intend to start a flame war but am just wondering since Mocha is a lot more popular (1620 vs 302240 npm downloads in last week)

@apfelbox apfelbox mentioned this pull request Jun 1, 2015
5 tasks
@lgiraudel lgiraudel closed this Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants