Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting issue with Git #357

Closed
KittyGiraudel opened this issue Sep 2, 2014 · 1 comment
Closed

Syntax highlighting issue with Git #357

KittyGiraudel opened this issue Sep 2, 2014 · 1 comment

Comments

@KittyGiraudel
Copy link

Regular expressions dealing with --- (deleted) and +++ (inserted) lines from Git diffs are slightly messed up when the line contains a ' token. You can see an example in latest code blocks from this article.

Ping @lgiraudel.
@lgiraudel
Copy link
Contributor

Fixed in the PR adding some jasmine tests #355 (not yet merged).

This said, I'm gonna check all examples in your awesome article, may be it will highlight some weird behaviors (strings in deleted / inserted lines for example).

@Golmote Golmote mentioned this issue Dec 13, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgiraudel @KittyGiraudel