Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing parentNode protection #1125

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: missing parentNode protection #1125

merged 1 commit into from
Apr 10, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 9, 2024

Changes

Patch for rrweb-io/rrweb#1445 until the next version of rrweb is released

@daibhin daibhin mentioned this pull request Apr 9, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Size Change: +45 B (0%)

Total Size: 947 kB

Filename Size Change
dist/array.full.js 225 kB +15 B (0%)
dist/recorder-v2.js 105 kB +15 B (0%)
dist/recorder.js 105 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.js 126 kB
dist/es.js 127 kB
dist/exception-autocapture.js 12.2 kB
dist/module.js 127 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@daibhin daibhin requested a review from a team April 9, 2024 16:50
pauldambra
pauldambra approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@daibhin daibhin added the bump patch Bump patch version when this PR gets merged label Apr 10, 2024
@daibhin daibhin merged commit 8edf88e into main Apr 10, 2024
12 checks passed
@daibhin daibhin deleted the dn-fix/parent-node-missing branch April 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daibhin @pauldambra @marandaneto