Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Session Recording Results in Error #21447

Closed
1 task done
dehli opened this issue Apr 9, 2024 · 7 comments
Closed
1 task done

User Session Recording Results in Error #21447

dehli opened this issue Apr 9, 2024 · 7 comments
Labels
bug Something isn't working right

Comments

@dehli
Copy link

dehli commented Apr 9, 2024

Bug description

Yesterday we started getting an error in our app triggered from Posthog hosted code:

Cannot read properties of null (reading 'tagName')

I was able to debug that it's related to user session recordings and disabling them prevents the error from showing more.

I have left it enabled on our dev instance so it can be more easily debugged.

How to reproduce

  1. Visit https://dev.vistaly.com
  2. Sign-in with: <redacted>
  3. Visit https://dev.vistaly.com/w/qewwIlH4Xf1R0cAt7jdOm
  4. Delete the card text (by clicking on it and then removing it in editor) and then start interacting in the app
image
  1. See console filled with error messages:
image

Environment

  • PostHog Cloud US, project ID: 29524

Additional context

@dehli dehli added the bug Something isn't working right label Apr 9, 2024
@daibhin
Copy link
Contributor

daibhin commented Apr 9, 2024

Thank you very much for the reproduction steps @dehli.

It looks like the latest version of our web capture tool (rrweb) made the changes causing this issue in a PR that was merged in the latest release: rrweb-io/rrweb#1351. We upgraded to the latest release yesterday, which perfectly lines up with when the error started occurring for you.

I've shipped a fix to their repo: rrweb-io/rrweb#1445 and added a patch to our own repo PostHog/posthog-js#1125

Thanks for reporting this 🙏

@dehli
Copy link
Author

dehli commented Apr 9, 2024

Thanks @daibhin for the speedy fix! Happy to help 😄 Should I go ahead and close issue or wait until the fix is deployed?

@daibhin
Copy link
Contributor

daibhin commented Apr 9, 2024

Let's wait until the fix gets out and you're confident that the issue has been fixed for you

@bookee-sid
Copy link

bookee-sid commented Apr 10, 2024

Hey @daibhin, when can we expect this fix to be merged and deployed? Can we get a ETA on this. Thanks

@daibhin
Copy link
Contributor

daibhin commented Apr 10, 2024

@bookee-sid I just merged the change. I should be live in the next hour or so. It will require that you upgrade your PostHog SDK to the latest version

@dehli
Copy link
Author

dehli commented Apr 10, 2024

Thanks again @daibhin for the quick fix! Just confirmed that the error is no longer occurring so I will go ahead and close this issue. Have a good one!

@dehli dehli closed this as completed Apr 10, 2024
@daibhin
Copy link
Contributor

daibhin commented Apr 10, 2024

Amazing, thanks @dehli for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

3 participants