[PIR] standardize the use of value[-5]. #57461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
force-pushed
the
cf_develop
branch
from
ebba76d
to
1ee3e13
Compare
zhangbo9674
previously approved these changes
Sep 18, 2023
winter-wang
force-pushed
the
cf_develop
branch
4 times, most recently
from
9a849eb
to
d2c422b
Compare
winter-wang
force-pushed
the
cf_develop
branch
from
d2c422b
to
673b5b7
Compare
zhangbo9674
approved these changes
Sep 19, 2023
Merged
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
规范化代码中对Value的使用[-5]。
Value分两种，OpResult和BlockArgument. 由于之前没有BlockArgument， 大家都是混用Value和OpResult， 现在有了BlockArguemnt, 需要区分Value和OpResult的使用。
在需要支持BlockArgument的地方，将原本的OpResult升级为Value，使其能够兼容BlockArgument的行为。
本pr内容：
-BlockArgument没有defining op，因此，本pr移除该接口。 对OpReusult而言，已存在功能等价的接口owner()。
参考pr:
Other
Pcard-67164