[PIR] standardize the use of value[-4]. #57373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winter-wang
changed the title
winter-wang
changed the title
winter-wang
force-pushed
the
cf_develop
branch
from
7f028de
to
cc07302
Compare
winter-wang
changed the title
winter-wang
changed the title
winter-wang
force-pushed
the
cf_develop
branch
25 times, most recently
from
4beb146
to
54b6e13
Compare
winter-wang
force-pushed
the
cf_develop
branch
from
54b6e13
to
1cfd559
Compare
Aurelius84
reviewed
Sep 18, 2023
| const std::vector<std::vector<bool>>& stop_gradients) { | ||
| return impl_->vjp_(op, out_grads, stop_gradients); | ||
| } | ||
|
|
||
| std::vector<std::vector<pir::OpResult>> Vjp( | ||
| pir::Operation* op, | ||
| const std::vector<std::vector<pir::OpResult>>& out_grads, |
There was a problem hiding this comment.
这里新增一个重载的Vjp 函数什么背景？我看上面是把入参类型由Value改为了OpResult
There was a problem hiding this comment.
上层python api调用vjp接口时，传递的是std::vector<std::vector<pir::OpResult>>。 但下层op build接口接受的参数在本次PR中被修正为了std::vector<std::vector<pir::Value>>。 中间存在gap。 OpResult是Value的派生类，这儿新增了一个重载接口，进行该参数的类型转换。
后续控制流支持python api的话，也需要逐步将python相关代码中部分对OpResult的使用替换为Value。
zhangbo9674
approved these changes
Sep 18, 2023
Aurelius84
approved these changes
Sep 18, 2023
winter-wang
changed the title
Merged
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
规范化代码中对Value的使用[-4]。
Value分两种，OpResult和BlockArgument. 由于之前没有BlockArgument， 大家都是混用Value和OpResult， 现在有了BlockArguemnt, 需要区分Value和OpResult的使用。
在需要支持BlockArgument的地方，将原本的OpResult升级为Value，使其能够兼容BlockArgument的行为。
本pr内容：
参考pr:
Other
Pcard-67164