[ Hackathon 3rd No.2 ] add paddle.iinfo #45321

OccupyMars2025 · 2022-08-22T14:26:50Z

PR types

New features

PR changes

APIs

Describe

add new API paddle.iinfo
docs: PaddlePaddle/docs#5235

The previous PR is closed by myself:
#44797

remove paddle.int8 from test

paddle-bot · 2022-08-22T14:26:55Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot · 2022-08-22T14:32:43Z

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

OccupyMars2025 · 2022-08-31T08:24:47Z

中文文档地址:
PaddlePaddle/docs#5235

cxxly · 2022-09-02T08:18:33Z

OccupyMars2025 · 2022-09-04T00:01:25Z

收到，谢谢，我再研究一下

…o-and-task2-add-iinfo-version002

OccupyMars2025 · 2022-09-04T00:21:14Z

try to solve the error reported by PR-CI-Coverage

In my opinion, one and only one of "from .core_noavx import iinfo" and "from .core_avx import iinfo" will be covered, so I delete both of them because "from .core_avx import * " and " from .core_noavx import * " can do the same things.

OccupyMars2025 · 2022-09-04T04:26:25Z

@cxxly PR-CI-Coverage的报错已解决，麻烦再看一下

cxxly

LGTM

Ligoml · 2022-09-06T06:50:17Z

python/paddle/framework/dtype.py

+        dtype: str, The string name of the argument dtype.
+
+    Raises:
+        ValueError: If the input "dtype" is not an integer paddle.dtype, it will raise an ValueError


raises删掉，这部分内容不建议在文档中体现，规范参考 API 文档书写规范

Ligoml · 2022-09-06T06:50:46Z

python/paddle/framework/dtype.py

+            print(iinfo_uint8.min)
+            print(iinfo_uint8.max)
+            print(iinfo_uint8.bits)
+            print(iinfo_uint8.dtype)


示例代码中，print的输出以注释的形式做展示，加在后面就好

Ligoml · 2022-09-06T06:51:35Z

python/paddle/framework/dtype.py

+
+    paddle.iinfo is a function that returns an object that represents the numerical properties of 
+    an integer paddle.dtype 
+    (i.e. paddle.uint8, paddle.int8, paddle.int16, paddle.int32, and paddle.int64). 


这里是不是和args中的dtype重复了？

Ligoml · 2022-09-06T06:52:05Z

python/paddle/framework/dtype.py

+    paddle.iinfo is a function that returns an object that represents the numerical properties of 
+    an integer paddle.dtype 
+    (i.e. paddle.uint8, paddle.int8, paddle.int16, paddle.int32, and paddle.int64). 
+    This is similar to numpy.iinfo.


给一个numpy.iinfo文档的超链接吧

OccupyMars2025 · 2022-09-06T07:15:47Z

收到，我尽快处理

OccupyMars2025 · 2022-09-06T21:02:42Z

@Ligoml 我已经按要求修改完了，麻烦再看一下

Ligoml · 2022-09-07T08:29:50Z

python/paddle/framework/dtype.py

+
+    paddle.iinfo is a function that returns an object that represents the numerical properties of 
+    an integer paddle.dtype.
+    This is similar to [numpy.iinfo](https://numpy.org/doc/stable/reference/generated/numpy.iinfo.html#numpy-iinfo).


超链接的解析是rst的方式，建议修改一下

Ligoml · 2022-09-07T08:34:08Z

python/paddle/framework/dtype.py

+    Args:
+        dtype(paddle.dtype):  One of paddle.uint8, paddle.int8, paddle.int16, paddle.int32, and paddle.int64.
+
+    Returns:


这里如果想让四个属性分行展示，需要修改一下格式，参考：

OccupyMars2025 · 2022-09-07T08:40:52Z

收到，我尽快处理

OccupyMars2025 · 2022-09-07T08:59:02Z

done

Ligoml

LGTM for docs

jeff41404

LGTM

OccupyMars2025 · 2022-09-09T23:49:13Z

In file explorer, search "data_type.h" and "data_type.cc". After studying all the files, you may find a way to handle with paddle.float16, paddle.bfloat16, paddle.complex128 in paddle.finfo()

"C:\Users\Administrator\Desktop\contests\20220704_paddle_hackathon\Paddle\paddle\fluid\framework\data_type.h"
"C:\Users\Administrator\Desktop\contests\20220704_paddle_hackathon\Paddle\paddle\phi\core\utils\data_type.h"
"C:\Users\Administrator\Desktop\contests\20220704_paddle_hackathon\Paddle\paddle\phi\common\data_type.h"
"C:\Users\Administrator\Desktop\contests\20220704_paddle_hackathon\Paddle\paddle\phi\capi\include\data_type.h"
"C:\Users\Administrator\Desktop\contests\20220704_paddle_hackathon\Paddle\paddle\infrt\dialect\phi\data_type.h"
and so on

OccupyMars2025 added 13 commits August 2, 2022 08:57

not finished yet

204fd69

Merge branch 'PaddlePaddle:develop' into hackathon-3rd-task2-add-iinfo

4008fc1

Update pybind.cc

645247e

Merge branch 'PaddlePaddle:develop' into hackathon-3rd-task2-add-iinfo

8da6c55

delete unrelated files

17e54e0

Update pybind.cc

89ad9f8

import iinfo

3e4c1fc

Create test_iinfo.py

dbea60b

Update test_iinfo.py

802ad53

remove paddle.int8 from test

Update test_iinfo.py

2d2ffd0

more properties

1cd38bd

add finfo

5589aa8

Update test_iinfo_and_finfo.py

c2ba90f

paddle-bot bot added contributor External developers status: proposed labels Aug 22, 2022

OccupyMars2025 closed this Aug 22, 2022

OccupyMars2025 deleted the hackathon-3rd-task1-add-finfo-and-task2-add-iinfo-version002 branch August 22, 2022 14:32

paddle-bot bot added status: not progressed and removed status: proposed labels Aug 22, 2022

OccupyMars2025 restored the hackathon-3rd-task1-add-finfo-and-task2-add-iinfo-version002 branch August 22, 2022 14:33

OccupyMars2025 reopened this Aug 22, 2022

OccupyMars2025 added 7 commits August 22, 2022 22:35

Update test_iinfo_and_finfo.py

f67e3d7

Update pybind.cc

e44f818

Update pybind.cc

c5fa801

resolution not equal

74ab8d5

Update test_iinfo_and_finfo.py

9b318ab

type check

94ef052

Update test_iinfo_and_finfo.py

169add9

OccupyMars2025 requested review from cxxly August 31, 2022 03:33

OccupyMars2025 added 2 commits September 4, 2022 08:08

Merge branch 'PaddlePaddle:develop' into hackathon-3rd-task1-add-finf…

afe4e96

…o-and-task2-add-iinfo-version002

Update core.py

cf221c9

cxxly previously approved these changes Sep 6, 2022

View reviewed changes

luotao1 requested a review from Ligoml September 6, 2022 03:03

Ligoml reviewed Sep 6, 2022

View reviewed changes

Update dtype.py

05dd1a7

OccupyMars2025 dismissed cxxly’s stale review via 05dd1a7 September 6, 2022 07:49

OccupyMars2025 added 2 commits September 7, 2022 15:18

Update dtype.py

a013bdf

Update dtype.py

bbdb3b5

Ligoml reviewed Sep 7, 2022

View reviewed changes

Update dtype.py

32ea2fa

for punctuation mark

623179f

Ligoml previously approved these changes Sep 7, 2022

View reviewed changes

Update grad_node_info.h

9113d68

OccupyMars2025 dismissed Ligoml’s stale review via 9113d68 September 7, 2022 11:39

jeff41404 approved these changes Sep 8, 2022

View reviewed changes

luotao1 merged commit 40a0a46 into PaddlePaddle:develop Sep 8, 2022

Caozhou1995 pushed a commit to Caozhou1995/Paddle that referenced this pull request Sep 9, 2022

[ Hackathon 3rd No.2 ] add paddle.iinfo (PaddlePaddle#45321)

628f2bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ Hackathon 3rd No.2 ] add paddle.iinfo #45321

[ Hackathon 3rd No.2 ] add paddle.iinfo #45321

OccupyMars2025 commented Aug 22, 2022 •

edited by Ligoml

Loading

paddle-bot bot commented Aug 22, 2022

paddle-bot bot commented Aug 22, 2022

OccupyMars2025 commented Aug 31, 2022

cxxly commented Sep 2, 2022

OccupyMars2025 commented Sep 4, 2022

OccupyMars2025 commented Sep 4, 2022 •

edited

Loading

OccupyMars2025 commented Sep 4, 2022

cxxly left a comment

Ligoml Sep 6, 2022

OccupyMars2025 Sep 6, 2022

Ligoml Sep 6, 2022

OccupyMars2025 Sep 6, 2022

Ligoml Sep 6, 2022

OccupyMars2025 Sep 6, 2022

Ligoml Sep 6, 2022

OccupyMars2025 Sep 6, 2022

OccupyMars2025 commented Sep 6, 2022

OccupyMars2025 commented Sep 6, 2022

Ligoml Sep 7, 2022

OccupyMars2025 Sep 7, 2022

Ligoml Sep 7, 2022

OccupyMars2025 Sep 7, 2022

OccupyMars2025 commented Sep 7, 2022

OccupyMars2025 commented Sep 7, 2022

Ligoml left a comment

jeff41404 left a comment

OccupyMars2025 commented Sep 9, 2022

[ Hackathon 3rd No.2 ] add paddle.iinfo #45321

[ Hackathon 3rd No.2 ] add paddle.iinfo #45321

Conversation

OccupyMars2025 commented Aug 22, 2022 • edited by Ligoml Loading

PR types

PR changes

Describe

paddle-bot bot commented Aug 22, 2022

paddle-bot bot commented Aug 22, 2022

OccupyMars2025 commented Aug 31, 2022

cxxly commented Sep 2, 2022

OccupyMars2025 commented Sep 4, 2022

OccupyMars2025 commented Sep 4, 2022 • edited Loading

try to solve the error reported by PR-CI-Coverage

In my opinion, one and only one of "from .core_noavx import iinfo" and "from .core_avx import iinfo" will be covered, so I delete both of them because "from .core_avx import * " and " from .core_noavx import * " can do the same things.

OccupyMars2025 commented Sep 4, 2022

cxxly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OccupyMars2025 commented Sep 6, 2022

OccupyMars2025 commented Sep 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OccupyMars2025 commented Sep 7, 2022

OccupyMars2025 commented Sep 7, 2022

Ligoml left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

OccupyMars2025 commented Sep 9, 2022

In file explorer, search "data_type.h" and "data_type.cc". After studying all the files, you may find a way to handle with paddle.float16, paddle.bfloat16, paddle.complex128 in paddle.finfo()

OccupyMars2025 commented Aug 22, 2022 •

edited by Ligoml

Loading

OccupyMars2025 commented Sep 4, 2022 •

edited

Loading