Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: update interfaces #2635

Merged
merged 6 commits into from
Oct 13, 2023
Merged

core: update interfaces #2635

merged 6 commits into from
Oct 13, 2023

Conversation

xenowits
Copy link
Contributor

Update SignedData interface to include:

  • Signatures() []Signature - Replaces Signature()
  • SetSignatures([]Signature) (SignedData, error) - Replaces SetSignature()
  • MessageRoots() ([][32]byte, error) - Replaces MessageRoot()
  • HashRoot() ([32]byte, error)

Also, update Eth2SignedData interface to include:

  • DomainNames() []signing.DomainName - Replaces DomainName()

These changes to the core interfaces are done in order to prepare for the upcoming deneb ethereum upgrade.

category: feature
ticket: #2597

@xenowits xenowits self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 160 lines in your changes are missing coverage. Please review.

Comparison is base (871bd33) 53.49% compared to head (bfb94e2) 53.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
- Coverage   53.49%   53.33%   -0.17%     
==========================================
  Files         202      202              
  Lines       27339    27501     +162     
==========================================
+ Hits        14625    14667      +42     
- Misses      10891    10986      +95     
- Partials     1823     1848      +25     
Files Coverage Δ
cmd/createcluster.go 59.82% <100.00%> (ø)
core/fetcher/fetcher.go 64.96% <100.00%> (ø)
core/proto.go 64.24% <100.00%> (+0.95%) ⬆️
core/tracker/tracker.go 79.51% <100.00%> (ø)
core/types.go 27.07% <ø> (ø)
dkg/dkg.go 57.12% <100.00%> (ø)
core/parsigdb/memory.go 53.90% <75.00%> (ø)
core/eth2signeddata.go 72.36% <75.67%> (-8.59%) ⬇️
core/sigagg/sigagg.go 63.72% <67.56%> (+1.70%) ⬆️
core/signeddata.go 42.66% <37.55%> (-4.92%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LFTM, left some comments that need addressing before giving the green light.

core/fetcher/fetcher.go Show resolved Hide resolved
core/parsigdb/memory.go Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
core/eth2signeddata.go Show resolved Hide resolved
core/signeddata.go Outdated Show resolved Hide resolved
core/signeddata.go Show resolved Hide resolved
core/types.go Outdated Show resolved Hide resolved
core/eth2signeddata.go Show resolved Hide resolved
core/types.go Outdated Show resolved Hide resolved
core/types.go Outdated Show resolved Hide resolved
core/proto.go Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 13, 2023
@obol-bulldozer obol-bulldozer bot merged commit 2fe130e into main Oct 13, 2023
12 of 13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/core-interfaces branch October 13, 2023 05:58
@xenowits xenowits mentioned this pull request Nov 3, 2023
3 tasks
gsora added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants