Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deneb support #2597

Closed
2 tasks done
xenowits opened this issue Sep 27, 2023 · 2 comments
Closed
2 tasks done

Implement deneb support #2597

xenowits opened this issue Sep 27, 2023 · 2 comments
Assignees
@xenowits
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

xenowits commented Sep 27, 2023 •
edited
Loading

🎯 Problem to be solved

Implement support for deneb.

🛠️ Proposed solution

Implement solution 2

🧪 Tests

We need to test deneb support on devnets: https://github.com/ethpandaops/dencun-testnet

Also, see https://dencun-devnet-8.ethpandaops.io/
@xenowits xenowits self-assigned this Sep 27, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Sep 27, 2023
@boulder225
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @gsora @dB2510 @xenowits

@xenowits xenowits mentioned this issue Sep 29, 2023
Closed
@xenowits xenowits mentioned this issue Oct 10, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 13, 2023
@xenowits
core: update interfaces (#2635)
2fe130e 
Update `SignedData` interface to include:
* `Signatures() []Signature` - Replaces `Signature()`
* `SetSignatures([]Signature) (SignedData, error)` - Replaces `SetSignature()`
* `MessageRoots() ([][32]byte, error)` - Replaces `MessageRoot()`
* `HashRoot() ([32]byte, error)`

Also, update `Eth2SignedData` interface to include:
* `DomainNames() []signing.DomainName` - Replaces `DomainName()`

These changes to the core interfaces are done in order to prepare for the upcoming deneb ethereum upgrade.

category: feature 
ticket: #2597
@xenowits
Copy link
Contributor Author

Closing this as changes to core interfaces is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xenowits @boulder225