Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to new deneb changes #2659

Closed
3 tasks
xenowits opened this issue Oct 26, 2023 · 0 comments
Closed
3 tasks

update to new deneb changes #2659

xenowits opened this issue Oct 26, 2023 · 0 comments
Assignees
@xenowits
Labels
protocol Protocol Team tickets v0.18.0

Comments

@xenowits
Copy link
Contributor

xenowits commented Oct 26, 2023 •
edited
Loading

🎯 Problem to be solved

There have been changes to the deneb spec recently(see PR).

We need to update our code to comply with the updated deneb specs.

🛠️ Proposed solution

Note that in the updated spec, we don't require signatures on blob sidecars. Hence, the change to our core interfaces doesn't make sense anymore as we now have a single signature per signed object.

  • Revert PR#2635
  • In all eth2spec.DataVersionDeneb cases, use only the SignedBeaconBlock signature.
    • There may be changes on the go-eth2-client side

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@xenowits xenowits self-assigned this Oct 26, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Oct 26, 2023
@xenowits xenowits changed the title add deneb support update to new deneb changes Nov 3, 2023
@xenowits xenowits mentioned this issue Nov 8, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Nov 8, 2023
@xenowits
core: revert core interfaces (#2682)
2593530 
Revert changes to core interfaces.

This is done since the deneb upgrade no longer requires multiple signatures per signed object. Reverting to the original implementation makes the interfaces simple and code much easier to reason about.

category: refactor
ticket: #2659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
protocol Protocol Team tickets v0.18.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xenowits