Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.requests-cache: remove attrs version constraint #187185

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 17, 2022

There is no functional reason why attrs (and cattrs) need to be
restricted, but the versions are in flux right now. Please read
and follow the following issue for the latest:

requests-cache/requests-cache#675

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 17, 2022

Targeting staging-next, because I believe it is broken on there and not yet on master.

There is no functional reason why attrs (and cattrs) need to be
restricted, but the versions are in flux right now. Please read
and follow the following issue for the latest:

  requests-cache/requests-cache#675
@tjni
Copy link
Contributor Author

tjni commented Aug 23, 2022

Linking to #186941.

@vcunat vcunat merged commit 2e602c5 into NixOS:staging-next Aug 24, 2022
@tjni tjni deleted the requests-cache branch August 25, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants