Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with clang #188087

Merged
merged 1 commit into from
Sep 17, 2022
Merged

vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with clang #188087

merged 1 commit into from
Sep 17, 2022

Conversation

codyps
Copy link
Contributor

@codyps codyps commented Aug 23, 2022 •
edited
Loading

  • vid-stab 1.1.0 (current release) hardcodes libgomp in its pkg-config.
    Current git version includes a commit fixing this, so this change
    updates to the git versions
  • placing openmp in buildInputs causes it not to be present when
    linking against vid-stab, causing linking to fail. Move it to
    propagatedBuildInputs to resolve
  • the all-packages.nix change enables vid-stab in (for example) ffmpeg
    on macos (where it was previously disabled).
Description of changes

Changes: georgmartius/vid.stab@60d65da...90c76ac

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin (and checked an ffmpeg-full build on the same)
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from codyopel August 23, 2022 20:56
@codyps
vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with c…
06b6e30 
…lang

 - vid-stab 1.1.0 (current release) hardcodes libgomp in its pkg-config.
   Current git version includes a commit fixing this, so this change
   updates to the git versions
 - placing openmp in `buildInputs` causes it not to be present when
   linking against vid-stab, causing linking to fail. Move it to
   `propagatedBuildInputs` to resolve
 - the all-packages.nix change enables vid-stab in (for example) ffmpeg
   on macos (where it was previously disabled).
@codyps codyps changed the title vid-stab: 1.1.0 -> git, fix linking against it with clang vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with clang Aug 23, 2022
@b12f
Copy link
Contributor

b12f commented Aug 23, 2022

Result of nixpkgs-review pr 188087 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • libsForQt512.kdenlive
  • libsForQt512.soundkonverter
  • libsForQt514.kdenlive
  • libsForQt514.soundkonverter
7 packages failed to build:
  • corrscope
  • obs-studio-plugins.obs-ndi
  • pixinsight
  • python310Packages.dm-sonnet
  • python310Packages.tensorflow-datasets
  • python39Packages.dm-sonnet
  • python39Packages.tensorflow-datasets
49 packages built:
  • MIDIVisualizer
  • arcanPackages.all-wrapped
  • arcanPackages.arcan
  • arcanPackages.arcan-wrapped
  • arcanPackages.durden-wrapped
  • ffmpeg-full (arcanPackages.ffmpeg)
  • arcanPackages.pipeworld-wrapped
  • arcanPackages.prio-wrapped
  • arcanPackages.xarcan
  • ffmpeg_5-full
  • handbrake
  • haruna
  • imagination
  • jellyfin
  • jellyfin-ffmpeg
  • libsForQt5.kdenlive (libsForQt515.kdenlive ,plasma5Packages.kdenlive)
  • libsForQt5.mlt (libsForQt515.mlt ,plasma5Packages.mlt)
  • soundkonverter (libsForQt5.soundkonverter)
  • libsForQt512.mlt
  • libsForQt514.mlt
  • liquidsoap
  • manim
  • media-downloader
  • megasync
  • obs-studio
  • obs-studio-plugins.looking-glass-obs
  • obs-studio-plugins.obs-backgroundremoval
  • obs-studio-plugins.obs-gstreamer
  • obs-studio-plugins.obs-move-transition
  • obs-studio-plugins.obs-multi-rtmp
  • obs-studio-plugins.obs-nvfbc
  • obs-studio-plugins.obs-pipewire-audio-capture
  • obs-studio-plugins.obs-vkcapture
  • obs-studio-plugins.obs-websocket
  • obs-studio-plugins.wlrobs
  • olive-editor
  • printrun
  • python310Packages.moderngl-window
  • python310Packages.pydub
  • python310Packages.pyglet
  • python310Packages.pytmx
  • python39Packages.moderngl-window
  • python39Packages.pydub
  • python39Packages.pyglet
  • python39Packages.pytmx
  • restream
  • shotcut
  • vid-stab
  • webcamoid

@codyps
Copy link
Contributor Author

codyps commented Aug 24, 2022

Result of nixpkgs-review pr 188087 run on x86_64-darwin 1

14 packages marked as broken and skipped:
  • arcanPackages.arcan
  • arcanPackages.xarcan
  • handbrake
  • liquidsoap
  • manim
  • media-downloader
  • python310Packages.dm-sonnet
  • python310Packages.pyglet
  • python310Packages.pytmx
  • python310Packages.tensorflow-datasets
  • python39Packages.dm-sonnet
  • python39Packages.pyglet
  • python39Packages.pytmx
  • python39Packages.tensorflow-datasets
2 packages failed to build:
  • corrscope
  • jellyfin
6 packages built:
  • ffmpeg-full (arcanPackages.ffmpeg)
  • ffmpeg_5-full
  • olive-editor
  • python310Packages.pydub
  • python39Packages.pydub
  • vid-stab

@codyps
Copy link
Contributor Author

codyps commented Aug 24, 2022

Result of nixpkgs-review pr 188087 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • libsForQt512.kdenlive
  • libsForQt512.soundkonverter
  • libsForQt514.kdenlive
  • libsForQt514.soundkonverter
6 packages failed to build:
  • corrscope
  • pixinsight
  • python310Packages.dm-sonnet
  • python310Packages.tensorflow-datasets
  • python39Packages.dm-sonnet
  • python39Packages.tensorflow-datasets
50 packages built:
  • MIDIVisualizer
  • arcanPackages.all-wrapped
  • arcanPackages.arcan
  • arcanPackages.arcan-wrapped
  • arcanPackages.durden-wrapped
  • ffmpeg-full (arcanPackages.ffmpeg)
  • arcanPackages.pipeworld-wrapped
  • arcanPackages.prio-wrapped
  • arcanPackages.xarcan
  • ffmpeg_5-full
  • handbrake
  • haruna
  • imagination
  • jellyfin
  • jellyfin-ffmpeg
  • libsForQt5.kdenlive (libsForQt515.kdenlive ,plasma5Packages.kdenlive)
  • libsForQt5.mlt (libsForQt515.mlt ,plasma5Packages.mlt)
  • soundkonverter (libsForQt5.soundkonverter)
  • libsForQt512.mlt
  • libsForQt514.mlt
  • liquidsoap
  • manim
  • media-downloader
  • megasync
  • obs-studio
  • obs-studio-plugins.looking-glass-obs
  • obs-studio-plugins.obs-backgroundremoval
  • obs-studio-plugins.obs-gstreamer
  • obs-studio-plugins.obs-move-transition
  • obs-studio-plugins.obs-multi-rtmp
  • obs-studio-plugins.obs-ndi
  • obs-studio-plugins.obs-nvfbc
  • obs-studio-plugins.obs-pipewire-audio-capture
  • obs-studio-plugins.obs-vkcapture
  • obs-studio-plugins.obs-websocket
  • obs-studio-plugins.wlrobs
  • olive-editor
  • printrun
  • python310Packages.moderngl-window
  • python310Packages.pydub
  • python310Packages.pyglet
  • python310Packages.pytmx
  • python39Packages.moderngl-window
  • python39Packages.pydub
  • python39Packages.pyglet
  • python39Packages.pytmx
  • restream
  • shotcut
  • vid-stab
  • webcamoid

@codyps
Copy link
Contributor Author

codyps commented Aug 24, 2022

FWIW:

#188087 (comment)

7 packages failed to build:

These are broken-by-default due to needing manually fetched src:

  • obs-studio-plugins.obs-ndi (needs NDI sdk src)
  • pixinsight (needs pixinsight src)

These were already broken:

  • corrscope (needs attrs version constraint removal/expansion, like python310Packages.requests-cache: remove attrs version constraint #187185)
  • python310Packages.dm-sonnet (ERROR: No matching distribution found for etils[epath], likely a similar constraint issue)
  • python310Packages.tensorflow-datasets (dep missing due to above dm-sonnet failure)
  • python39Packages.dm-sonnet (same as python310)
  • python39Packages.tensorflow-datasets (same as python310)

@b12f
Copy link
Contributor

b12f commented Aug 24, 2022

Not sure what the process is here then. Should these be explicitly marked as broken?

@marsam marsam merged commit a5e503c into NixOS:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codyps @b12f @marsam @Janik-Haag