staging-next 2022-08-16 #186941
Merged
staging-next 2022-08-16 #186941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vcunat
commented
Aug 16, 2022
vcunat
commented
- workflow docs: nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
- important job(s): hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
- jobset: hydra.nixos.org/jobset/nixpkgs/staging-next
- nix-review reports: https://malob.github.io/nix-review-tools-reports/
- previous staging-next: staging-next 2022-08-06 #185426
Prevent glib.dev reference from ending up in out due to glib being propagated.
Prevent brotli.dev reference from ending up in out due to brotli being propagated.
The initial intent was to strip .a and .o files, not .a.o files. While at it expanded stripping for $lib output as well. Without the change `libgcc.a` was not stripped and `.debug*` sections made into final binaries. It's not a problem on it's own, but it's an unintended side-effect. Noticed on `crystal_1_0` test failure where `crystal` was not able to handle `dwarf-5`. While at it allowed absolute file names to be passed to stripDebugList and friends.
Our gcc builder creates lib64->lib links to ensure that the "primary" libraries for the targetPlatform wind up in $PREFIX/lib. This is required in order for make-bootstrap-files.nix to work correctly. On mips, gcc follows the somewhat awkward IRIX convention of putting mips32 binaries in `lib` and mips64n32 binaries in `lib32`. So we need similar symlinks there. This may come up on other ILP32 platforms as well, so a general-purpose variable name is provided.
On mips, gcc follows the somewhat awkward IRIX convention of putting mips64 binaries in `lib64` and mips64n32 binaries in `lib32`. So on mips64n32 we do not want the `lib64` symlinks.
This commit factors out the conditional which creates the `lib64->lib` symlink in the `preInstall` phase, and calculates its value in nix code rather than bash code so touching it doesn't cause a global rebuild on every platform.
bintools-wrapper, cc-wrapper: avoid invalid export of 'expand-respons…
gcc: extend stripping of .a libraries and .o objects
Before the change separate-debug-info.sh did the stripping itself. This scheme has a few problems: 1. Stripping happens only on ELF files. *.a and *.o files are skipped. Derivations have to do it manually. Usually incorrectly as they don't run $RANLIB (true for `glibc` and `musl`). 2. Stripping happens on all paths. Ideally only `stripDebugList` paths should be considered. 3. Host strip is called on Target files. This change offloads stripping logic to strip hook. This strips more files for `glibc` and `musl`. Now we can remove most $STRIP calls from individual derivations. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Noticed use of $STRIP when passed through various uses of $STRIP in `nixpkgs`. This looked unusual in a way that it strips not just debugging symbols but also all the rest. The change switch to debug-only stripping. While at it switched to expliict use of `-fPIC` for shared library.
zlib: add patch for CVE-2022-37434
gsm: 1.0.19 -> 1.0.20
glib: add man pages, make bash completion work
Small release. Most interesting chage is support for binutils-2.39
(non-executable GNU stack marking).
4 changes in this release:
Handle __mips64
Bump revision to VERSION = 3.0.15
lib/Makefile: add .o file dependency on libsubdirs targets
*/*.S: add non-executable GNU stack marking on ELF-linux
|
Right, no upstream patch. We should mark it broken and eventually remove. |
Shortly discussed on: #186941 (comment)
github-actions
bot
added
the
6.topic: GNOME
|
For people who want to help, now is a relatively good moment to look at regressions, though there aren't really many (and some get covered in PR #187778): |
13 tasks
...into staging-next
...into staging-next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.