Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.bitstring: fix unit tests #187531

Merged
merged 1 commit into from
Aug 21, 2022
Merged

python310Packages.bitstring: fix unit tests #187531

merged 1 commit into from
Aug 21, 2022
+9 −0

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2022 •
edited
Loading

The unit tests are broken on staging by the new unittest hook, because this project did not run its tests using unittest from project root. For now, I've submitted a patch upstream and pulled it in here so that the build is unblocked.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 19, 2022
Merged
@ofborg ofborg bot requested a review from bjornfor August 19, 2022 23:22
@vcunat vcunat mentioned this pull request Aug 20, 2022
Merged
13 tasks
@tjni
python310Packages.bitstring: fix unit tests
c37f44b 
The unit tests are broken on staging by the new unittest hook, because
this project did not run its tests using `unittest` from project root.
For now, I've submitted a patch upstream and pulled it in here so that
the build is unblocked.
@ofborg ofborg bot requested a review from bjornfor August 20, 2022 08:21
@SuperSandro2000 SuperSandro2000 merged commit 9fdef95 into NixOS:staging-next Aug 21, 2022
@tjni tjni deleted the fix-bitstring branch August 21, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt winterqt requested changes

@bjornfor bjornfor bjornfor approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjni @bjornfor @SuperSandro2000 @winterqt @bobby285271