Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck if empty under lock, early exit #7442

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Sep 16, 2024

Changes

  • Once the ConcurrentDIctionary lock is acquired, recheck if the collection is empty before trying to clear it
  • Remove some additional clears of preWarm cache as over clearing them
  • Allow prewarm cache to clear in background on prewarm continuation; only forcing at start of next block if not cleared

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit 55aa224 into master Sep 18, 2024
66 checks passed
@benaadams benaadams deleted the recheck-under-lock branch September 18, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants