Allow precache to clear in background #7438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,7 @@ public Task PreWarmCaches(Block suggestedBlock, Hash256? parentStateRoot, Access | |||
| { | |||
| if (targetWorldState.ClearCache()) | |||
| { | |||
| if (_logger.IsWarn) _logger.Warn("Caches are not empty. Clearing them."); | |||
| if (_logger.IsDebug) _logger.Debug("Caches are not empty. Clearing them."); | |||
There was a problem hiding this comment.
This generally should not happen in normal execution, why lower to Debug?
| @@ -40,6 +40,12 @@ public static bool NoResizeClear<TKey, TValue>(this ConcurrentDictionary<TKey, T | |||
|
|
|||
| using var handle = dictionary.AcquireLock(); | |||
|
|
|||
| // Recheck under lock | |||
| if (dictionary is null || dictionary.IsEmpty) | |||
There was a problem hiding this comment.
dictionary?.IsEmpty == false
There was a problem hiding this comment.
dictionary?.IsEmpty == false
Crashes with that
dictionary?.IsEmpty ?? true works though
| @@ -330,7 +330,6 @@ public void CommitTrees(long blockNumber) | |||
| _toUpdateRoots.Clear(); | |||
| // only needed here as there is no control over cached storage size otherwise | |||
| _storages.Clear(); | |||
| _preBlockCache?.NoResizeClear(); | |||
| @@ -857,7 +857,6 @@ public void CommitTree(long blockNumber) | |||
| } | |||
|
|
|||
| _tree.Commit(blockNumber); | |||
| _preBlockCache?.NoResizeClear(); | |||
|
Something not happy with this. Will make a simpler PR |
|
Simpler that is kinda and optimiaztion bug fix #7442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing