Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CI script file name #445

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix typo in CI script file name #445

merged 1 commit into from
Jul 11, 2022

Conversation

karlhigley
Copy link
Contributor

No description provided.

@karlhigley karlhigley added the bug Something isn't working label Jul 11, 2022
@karlhigley karlhigley added this to the Merlin 22.07 milestone Jul 11, 2022
@karlhigley karlhigley self-assigned this Jul 11, 2022
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #445 of commit fb08a65085f475183c2e285849e8a2f35412eec9, no merge conflicts.
Running as SYSTEM
Setting status of fb08a65085f475183c2e285849e8a2f35412eec9 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/252/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/445/*:refs/remotes/origin/pr/445/* # timeout=10
 > git rev-parse fb08a65085f475183c2e285849e8a2f35412eec9^{commit} # timeout=10
Checking out Revision fb08a65085f475183c2e285849e8a2f35412eec9 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fb08a65085f475183c2e285849e8a2f35412eec9 # timeout=10
Commit message: "Fix typo in CI script file name"
 > git rev-list --no-walk f6f4204bafea13467f9788db0a31ab4000a69cec # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins11088997146970034305.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

========================= 2 passed in 90.45s (0:01:30) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins5483215883613071379.sh

@karlhigley karlhigley merged commit e52d249 into main Jul 11, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-445

jperez999 added a commit that referenced this pull request Jul 12, 2022
* minor tweaks to the unit test

* unit test to now respect NUM_ROWS env var
* unit test can now be run in a single docker container with different
NUM_ROWS values (hopefully, different data overall)

* add integration tests

* increase integration test timeout

* set minimal NUM_ROWS for neccessary features to be generated

* switch back to a single test comprising two notebooks

* restructure integration test to prevent OOM error

* remove old file

* remove test_integration.sh

* add changes from Julio

* Fix typo in CI script file name (#445)

* update notebook

Co-authored-by: Benedikt Schifferer <bschifferer@nvidia.com>
Co-authored-by: rnyak <ronayak@hotmail.com>
Co-authored-by: Julio Perez <37191411+jperez999@users.noreply.github.com>
Co-authored-by: Karl Higley <kmhigley@gmail.com>
@mikemckiernan mikemckiernan deleted the fix/ci-script-typo branch August 3, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants