add integration tests #310
Conversation
* unit test to now respect NUM_ROWS env var * unit test can now be run in a single docker container with different NUM_ROWS values (hopefully, different data overall)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click to view CI ResultsGitHub pull request #310 of commit 83bb4a4a82a88e0084f33c3b8727114993cca849, no merge conflicts.
Running as SYSTEM
Setting status of 83bb4a4a82a88e0084f33c3b8727114993cca849 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/84/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 83bb4a4a82a88e0084f33c3b8727114993cca849^{commit} # timeout=10
Checking out Revision 83bb4a4a82a88e0084f33c3b8727114993cca849 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 83bb4a4a82a88e0084f33c3b8727114993cca849 # timeout=10
Commit message: "minor tweaks to the unit test"
> git rev-list --no-walk c021dca3f3b3c3b4f22a5dbdac6d169794e62b43 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins5359037390836984114.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item
|
Documentation preview |
Click to view CI ResultsGitHub pull request #310 of commit 65e67e4210ab9c51f3a29aaa57908f8007037c13, no merge conflicts.
Running as SYSTEM
Setting status of 65e67e4210ab9c51f3a29aaa57908f8007037c13 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/86/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 65e67e4210ab9c51f3a29aaa57908f8007037c13^{commit} # timeout=10
Checking out Revision 65e67e4210ab9c51f3a29aaa57908f8007037c13 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 65e67e4210ab9c51f3a29aaa57908f8007037c13 # timeout=10
Commit message: "add integration tests"
> git rev-list --no-walk 0b30e36dff54652a29ff907b2bd4db0d9cdf44a5 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins5381974920103876364.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item
|
|
Finally! 🥳 This is now passing on ngc, works okay with a 32GB GPU. Both the unit and integration tests run okay. @bschifferer this is good to go AFAICT 🙂 |
Click to view CI ResultsGitHub pull request #310 of commit 7baaffeaf1b3540abf8034fa3705d0d824693aae, no merge conflicts.
Running as SYSTEM
Setting status of 7baaffeaf1b3540abf8034fa3705d0d824693aae to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/99/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 7baaffeaf1b3540abf8034fa3705d0d824693aae^{commit} # timeout=10
Checking out Revision 7baaffeaf1b3540abf8034fa3705d0d824693aae (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 7baaffeaf1b3540abf8034fa3705d0d824693aae # timeout=10
Commit message: "set minimal NUM_ROWS for neccessary features to be generated"
> git rev-list --no-walk 57bbeeaaab6333aaf4fc3a62d4635b98a85444fe # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins246541060742489711.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item
|
| / "examples/Building-and-deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb", | ||
| execute=False | ||
| ) | ||
| def test_nb2(tb): |
There was a problem hiding this comment.
I think the original unittest was one unittest and this one is splitted into two.
The 2nd unittest depends on artificats from the first unittest. That's the reason we decided to have it as one unittest. If the unittests are executed in a different order and/or only the 2nd one is executed, it will fail. I think it should be one unittest?
There was a problem hiding this comment.
That's a good point! I didn't realize we were keeping these test together due to the dependency issue, you are right. Will revert to how it was before.
The problem I encountered which prompted this change was that now with running on much bigger data I was running out of GPU RAM when this was a single test. But maybe this was due to some other issue in the code at that time.
Will switch to this being a single test, rerun the code on a 32GB GPU on ngc and if there will be issues will see if I can shutdown the first NB or clear the state via some other means when running the 2nd one.
|
Finally got this to pass on an ngc instance with a 32 GPU 🙂 The integration test is formatted rather weirdly, but that is because regardless of what I tried, I was getting an OOM error. If the first notebook is used in the decorator, no matter what I tried, the state was retained inside the function after the execution of |
Click to view CI ResultsGitHub pull request #310 of commit d02b886ca617b4c50d6c0ca212a2a94e643c2273, no merge conflicts.
Running as SYSTEM
Setting status of d02b886ca617b4c50d6c0ca212a2a94e643c2273 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/184/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse d02b886ca617b4c50d6c0ca212a2a94e643c2273^{commit} # timeout=10
Checking out Revision d02b886ca617b4c50d6c0ca212a2a94e643c2273 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f d02b886ca617b4c50d6c0ca212a2a94e643c2273 # timeout=10
Commit message: "remove old file"
> git rev-list --no-walk 78e5517833cdeee3098c0dfee21b533574367266 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14877655528659584999.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped
|
Click to view CI ResultsGitHub pull request #310 of commit d02b886ca617b4c50d6c0ca212a2a94e643c2273, no merge conflicts.
Running as SYSTEM
Setting status of d02b886ca617b4c50d6c0ca212a2a94e643c2273 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/185/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse d02b886ca617b4c50d6c0ca212a2a94e643c2273^{commit} # timeout=10
Checking out Revision d02b886ca617b4c50d6c0ca212a2a94e643c2273 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f d02b886ca617b4c50d6c0ca212a2a94e643c2273 # timeout=10
Commit message: "remove old file"
> git rev-list --no-walk d02b886ca617b4c50d6c0ca212a2a94e643c2273 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7431155745880002146.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit d02b886ca617b4c50d6c0ca212a2a94e643c2273, no merge conflicts.
Running as SYSTEM
Setting status of d02b886ca617b4c50d6c0ca212a2a94e643c2273 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/186/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse d02b886ca617b4c50d6c0ca212a2a94e643c2273^{commit} # timeout=10
Checking out Revision d02b886ca617b4c50d6c0ca212a2a94e643c2273 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f d02b886ca617b4c50d6c0ca212a2a94e643c2273 # timeout=10
Commit message: "remove old file"
> git rev-list --no-walk d02b886ca617b4c50d6c0ca212a2a94e643c2273 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins6875966861059290728.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item / 1 skipped
|
Click to view CI ResultsGitHub pull request #310 of commit 312309d857c8f0a00dc2cbb103404a947235da9e, no merge conflicts.
Running as SYSTEM
Setting status of 312309d857c8f0a00dc2cbb103404a947235da9e to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/188/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 312309d857c8f0a00dc2cbb103404a947235da9e^{commit} # timeout=10
Checking out Revision 312309d857c8f0a00dc2cbb103404a947235da9e (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 312309d857c8f0a00dc2cbb103404a947235da9e # timeout=10
Commit message: "remove test_integration.sh"
> git rev-list --no-walk 5b85d03a3b7168e24aca9b93d54f62c6956bdb0b # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins10113514030964541433.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 312309d857c8f0a00dc2cbb103404a947235da9e, no merge conflicts.
Running as SYSTEM
Setting status of 312309d857c8f0a00dc2cbb103404a947235da9e to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/192/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 312309d857c8f0a00dc2cbb103404a947235da9e^{commit} # timeout=10
Checking out Revision 312309d857c8f0a00dc2cbb103404a947235da9e (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 312309d857c8f0a00dc2cbb103404a947235da9e # timeout=10
Commit message: "remove test_integration.sh"
> git rev-list --no-walk dc58221b596e045bad21191326e3a7cd17390894 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins789959489837985382.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 312309d857c8f0a00dc2cbb103404a947235da9e, no merge conflicts.
Running as SYSTEM
Setting status of 312309d857c8f0a00dc2cbb103404a947235da9e to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/193/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 312309d857c8f0a00dc2cbb103404a947235da9e^{commit} # timeout=10
Checking out Revision 312309d857c8f0a00dc2cbb103404a947235da9e (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 312309d857c8f0a00dc2cbb103404a947235da9e # timeout=10
Commit message: "remove test_integration.sh"
> git rev-list --no-walk 312309d857c8f0a00dc2cbb103404a947235da9e # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14525379663961449664.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 726920d68e44235e299762efaaa197c84d54c8c5, no merge conflicts.
Running as SYSTEM
Setting status of 726920d68e44235e299762efaaa197c84d54c8c5 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/202/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 726920d68e44235e299762efaaa197c84d54c8c5^{commit} # timeout=10
Checking out Revision 726920d68e44235e299762efaaa197c84d54c8c5 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 726920d68e44235e299762efaaa197c84d54c8c5 # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk 5bbc1eb6712d321c7653e065a7ef353692b1c952 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins12539951437577628005.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 726920d68e44235e299762efaaa197c84d54c8c5, no merge conflicts.
Running as SYSTEM
Setting status of 726920d68e44235e299762efaaa197c84d54c8c5 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/206/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 726920d68e44235e299762efaaa197c84d54c8c5^{commit} # timeout=10
Checking out Revision 726920d68e44235e299762efaaa197c84d54c8c5 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 726920d68e44235e299762efaaa197c84d54c8c5 # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk e3aba3baef65212324b6bbd99f3f05faf7d42924 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins13736146507602789816.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 726920d68e44235e299762efaaa197c84d54c8c5, no merge conflicts.
Running as SYSTEM
Setting status of 726920d68e44235e299762efaaa197c84d54c8c5 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/207/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 726920d68e44235e299762efaaa197c84d54c8c5^{commit} # timeout=10
Checking out Revision 726920d68e44235e299762efaaa197c84d54c8c5 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 726920d68e44235e299762efaaa197c84d54c8c5 # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk 726920d68e44235e299762efaaa197c84d54c8c5 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins15044459486689579586.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
Click to view CI ResultsGitHub pull request #310 of commit 52fd61a228158a204c5768e8e1cd6eb75ace983a, no merge conflicts.
Running as SYSTEM
Setting status of 52fd61a228158a204c5768e8e1cd6eb75ace983a to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/210/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 52fd61a228158a204c5768e8e1cd6eb75ace983a^{commit} # timeout=10
Checking out Revision 52fd61a228158a204c5768e8e1cd6eb75ace983a (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 52fd61a228158a204c5768e8e1cd6eb75ace983a # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk e1ea188c5d1345635ec3919236595f29354884f6 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins1115888887326359012.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
Click to view CI ResultsGitHub pull request #310 of commit e5dc74db44acafafb48d9097ca83fbae3104b578, no merge conflicts.
Running as SYSTEM
Setting status of e5dc74db44acafafb48d9097ca83fbae3104b578 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/212/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse e5dc74db44acafafb48d9097ca83fbae3104b578^{commit} # timeout=10
Checking out Revision e5dc74db44acafafb48d9097ca83fbae3104b578 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f e5dc74db44acafafb48d9097ca83fbae3104b578 # timeout=10
Commit message: "add changes from Julio"
> git rev-list --no-walk 54c67635b3260bad14b1493e523c091a86cd3fba # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7464855418943512765.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
Click to view CI ResultsGitHub pull request #310 of commit 071da271939cdc0956baab073333435a307ab260, no merge conflicts.
Running as SYSTEM
Setting status of 071da271939cdc0956baab073333435a307ab260 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/222/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 071da271939cdc0956baab073333435a307ab260^{commit} # timeout=10
Checking out Revision 071da271939cdc0956baab073333435a307ab260 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 071da271939cdc0956baab073333435a307ab260 # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk 601f7828a6eb2293cff382aed4ae7e9b0183839b # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins10282615654877141105.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
Click to view CI ResultsGitHub pull request #310 of commit 3f0d332dce3a80d86abc017b0283f44c985ec79a, no merge conflicts.
Running as SYSTEM
Setting status of 3f0d332dce3a80d86abc017b0283f44c985ec79a to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/238/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 3f0d332dce3a80d86abc017b0283f44c985ec79a^{commit} # timeout=10
Checking out Revision 3f0d332dce3a80d86abc017b0283f44c985ec79a (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 3f0d332dce3a80d86abc017b0283f44c985ec79a # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins3331855544741952590.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
|
rerun tests |
Click to view CI ResultsGitHub pull request #310 of commit 3f0d332dce3a80d86abc017b0283f44c985ec79a, no merge conflicts.
Running as SYSTEM
Setting status of 3f0d332dce3a80d86abc017b0283f44c985ec79a to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/249/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 3f0d332dce3a80d86abc017b0283f44c985ec79a^{commit} # timeout=10
Checking out Revision 3f0d332dce3a80d86abc017b0283f44c985ec79a (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 3f0d332dce3a80d86abc017b0283f44c985ec79a # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk b8464675229dc47220fbdaa54583df1135c81850 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins8813610631507582293.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
| @@ -126,7 +126,24 @@ | |||
| "outputs": [ | |||
| { | |||
| "data": { | |||
| "application/javascript": "\n setTimeout(function() {\n var nbb_cell_id = 1;\n var nbb_unformatted_code = \"%load_ext nb_black\\n# for running this example on GPU, install the following libraries\\n# %pip install tensorflow \\\"feast<0.20\\\" faiss-gpu\\n\\n# for running this example on CPU, uncomment the following lines\\n# %pip install tensorflow-cpu \\\"feast<0.20\\\" faiss-cpu\\n# %pip uninstall cudf\";\n var nbb_formatted_code = \"%load_ext nb_black\\n# for running this example on GPU, install the following libraries\\n# %pip install tensorflow \\\"feast<0.20\\\" faiss-gpu\\n\\n# for running this example on CPU, uncomment the following lines\\n# %pip install tensorflow-cpu \\\"feast<0.20\\\" faiss-cpu\\n# %pip uninstall cudf\";\n var nbb_cells = Jupyter.notebook.get_cells();\n for (var i = 0; i < nbb_cells.length; ++i) {\n if (nbb_cells[i].input_prompt_number == nbb_cell_id) {\n if (nbb_cells[i].get_text() == nbb_unformatted_code) {\n nbb_cells[i].set_text(nbb_formatted_code);\n }\n break;\n }\n }\n }, 500);\n ", | |||
| "application/javascript": [ | |||
There was a problem hiding this comment.
remove this change and the tests seem to work. I would replace this code box with a text box that just tells them the command to run.
Click to view CI ResultsGitHub pull request #310 of commit f6f4204bafea13467f9788db0a31ab4000a69cec, no merge conflicts.
Running as SYSTEM
Setting status of f6f4204bafea13467f9788db0a31ab4000a69cec to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/251/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse f6f4204bafea13467f9788db0a31ab4000a69cec^{commit} # timeout=10
Checking out Revision f6f4204bafea13467f9788db0a31ab4000a69cec (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f f6f4204bafea13467f9788db0a31ab4000a69cec # timeout=10
Commit message: "Merge branch 'main' into add_integration_test"
> git rev-list --no-walk c6c42ab73191527377e55fd406003ad81c6c5a46 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14144039519244395743.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
…ki/Merlin into radekosmulski-add_integration_test
Click to view CI ResultsGitHub pull request #310 of commit 1b54899459f3a4ec98239777930a8964df8a472b, no merge conflicts.
Running as SYSTEM
Setting status of 1b54899459f3a4ec98239777930a8964df8a472b to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/253/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/310/*:refs/remotes/origin/pr/310/* # timeout=10
> git rev-parse 1b54899459f3a4ec98239777930a8964df8a472b^{commit} # timeout=10
Checking out Revision 1b54899459f3a4ec98239777930a8964df8a472b (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 1b54899459f3a4ec98239777930a8964df8a472b # timeout=10
Commit message: "update notebook"
> git rev-list --no-walk fb08a65085f475183c2e285849e8a2f35412eec9 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins13362131540554656512.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items
|
Should be good to go now, I left a bunch of comments in the associated issue
resolves #214