Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Ocean_ice_boundary to combined Ice-ocean driver #89

Closed

Conversation

theresa-morrison
Copy link
Contributor

@theresa-morrison theresa-morrison commented Aug 7, 2023

Adds a needed optional argument to the update_slow_ice_and_ocean call to pass the Ocean_ice_boundary type. This new optional argument is needed to properly use the interspersed coupling option.

This change should not impact the solutions to any experiments not using the combined-ice ocean driver. At compile time the new optional argument requires a SIS2 version with commit 0006cd2 or ice_null version with commit c9afb0d.

This PR is to associated with Issue #90.

Add new optional arguement to update_slow_ice_and_ocean call to pass the
Ocean_ice_boundary type. This new optional argument is needed to
properly use the interspersed coupling option.
@rem1776
Copy link
Contributor

rem1776 commented Aug 7, 2023

@theresa-morrison It looks like the the failing build test isn't related to your code changes, our test uses ice_null instead of sis2 so the interface will need to be modified there in order to compile the test.

I'll rerun the test when that change goes through, the pr should be linked above.

@rem1776 rem1776 requested a review from bensonr August 7, 2023 19:04
@theresa-morrison
Copy link
Contributor Author

Hi Ryan, thanks for letting me know. I see you already opened a PR to ice_null I will keep an eye on that. Let me know if we should have a meeting about this change.

@theresa-morrison
Copy link
Contributor Author

Hi Ryan, I saw that the PR to ice_null was accepted so I added the commit tag to this PR.

@thomas-robinson
Copy link
Member

This is a very high level interface update. Can this information be added somewhere else? Can it be put into one of the derived types that's already being passed into the update_slow_ice_and_ocean subroutine? Is this going to affect any models that are not running SIS2? The AM4 runs with SIS. We should avoid changing the coupler as much as possible.

@thomas-robinson
Copy link
Member

@theresa-morrison Can you help update the other ice models that will need to be updated to accommodate these changes? We either need to update all of the GFDL supported ice models, or these changes need to stay internal to SIS2 and not be done at the coupler level.

@thomas-robinson
Copy link
Member

@theresa-morrison have you been able to work on the other ice models?

@theresa-morrison
Copy link
Contributor Author

Hi Tom, I have been trying to correct some problems in the coupling within the sea-ice model and that has been my priority for the last few weeks. I will just close this PR and the associated issue until I am ready to work on the sea-ice models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants