Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed precision exchange #1318

Closed
wants to merge 58 commits into from
Closed

Conversation

mcallic2
Copy link
Contributor

@mcallic2 mcallic2 commented Aug 3, 2023

Description
All real values will be calculated as r8_kind

Fixes # (issue)

How Has This Been Tested?
Autotools with intel and gcc

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

J-Lentz and others added 30 commits February 1, 2023 08:28
…DL#1125)

Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
* fix: fms2 io performance update for domain_reads (NOAA-GFDL#1226)

* fix: fms2 io performance update for compressed writes (NOAA-GFDL#1227)

* chore: build/log updates for patch (NOAA-GFDL#1247)

Co-authored-by: uramirez8707 <49168881+uramirez8707@users.noreply.github.com>
Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
…re, and fms_mod (NOAA-GFDL#1239) (NOAA-GFDL#1258)

* feat: mixed precision axis_utils2 (NOAA-GFDL#1104)

* feat: mixed precision fms_mod (NOAA-GFDL#1147)

* feat: horiz interp mixed precision (NOAA-GFDL#1067)

* mixed precision sat_vapor_pressure  (NOAA-GFDL#1095)

* feat: add mixed precision axis_utils unit tests (NOAA-GFDL#1172)

* fix: move type definitions to before first usage to fix nvhpc bug (NOAA-GFDL#1187)

* fix: change allocatable type for intel errors (NOAA-GFDL#1221)

Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com>
Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
…1064)

BREAKING CHANGE: This commit removes mpp_io_mod and fms_io_mod, along with other routines that use the modules, from default compilation. The -Duse_deprecated_io CPP flag or --enable-deprecated-io configure time flag can be used to enable their compilation.
@mcallic2 mcallic2 marked this pull request as ready for review August 3, 2023 20:12
@mcallic2 mcallic2 requested review from J-Lentz and mlee03 August 3, 2023 20:12
@mlee03
Copy link
Contributor

mlee03 commented Aug 4, 2023

@mcallic2, while we're at it, would you mind fixing all the "Warning: Conversion from INTEGER(4) to INTEGER(8)" in exchange?

Copy link
Contributor

@mlee03 mlee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcallic2 can you merge in mixedmode?

@@ -0,0 +1,68 @@
#***********************************************************************
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should .github be updated to that in mixedmode?

Copy link
Contributor Author

@mcallic2 mcallic2 Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may have been me messing up the mixedmode merge, really not sure though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcallic2 this

exchange/xgrid.F90 Outdated Show resolved Hide resolved
exchange/xgrid.F90 Outdated Show resolved Hide resolved
exchange/xgrid.F90 Outdated Show resolved Hide resolved
exchange/xgrid.F90 Outdated Show resolved Hide resolved
test_fms/exchange/test_xgrid.F90 Outdated Show resolved Hide resolved
@mcallic2
Copy link
Contributor Author

@mcallic2 can you merge in mixedmode?

@mlee03 this is up to date with mixedmode

@mcallic2
Copy link
Contributor Author

./github directory is bugging me

@mcallic2 mcallic2 closed this Aug 17, 2023
@mcallic2 mcallic2 deleted the exchange branch October 6, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.