Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc site deployment #1078

Merged
merged 2 commits into from
Jun 29, 2023
Merged

update doc site deployment #1078

merged 2 commits into from
Jun 29, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Nov 23, 2022

Description
updates the docs workflow to use github's own action for deployment instead of the third party one I had used. I used a more recent example from seth with the current github recommended way to deploy.

It used to be required that you had an explicit branch (gh-pages) to deploy to the site, but this update will change it to an artifact (saved in the action) instead.

Fixes # (issue)

How Has This Been Tested?
testing on my fork

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@underwoo
Copy link
Member

@rem1776 currently, the deploy only works from the 'main'|'master' branch. At least, that is what I found in my tests.

@rem1776 rem1776 marked this pull request as ready for review November 28, 2022 16:02
@rem1776 rem1776 merged commit 84b330a into NOAA-GFDL:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants