Cleanup compiler warnings and errors #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amametjanov
commented
Jun 19, 2020
| @@ -210,6 +210,7 @@ function th_from_psi_base(this,psi) result(th) | |||
| class(wrf_type) :: this | |||
| real(r8),intent(in) :: psi | |||
| real(r8) :: th | |||
| th = 0._r8 | |||
There was a problem hiding this comment.
This is just to avoid IBM compiler warning with th as uninitialized function result:
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesHydroWTFMod.F90", 1513-083 (E) Internal or module function ftc was not set within the function.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesHydroWTFMod.F90", 1513-083 (E) Internal or module function dftcdpsi was not set within the function.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesHydroWTFMod.F90", 1513-083 (E) Internal or module function dpsidth was not set within the function.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesHydroWTFMod.F90", 1513-083 (E) Internal or module function th was not set within the function.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesHydroWTFMod.F90", 1513-083 (E) Internal or module function psi was not set within the function.
| @@ -567,7 +567,7 @@ subroutine FatesReportParams(is_master) | |||
| write(fates_log(),fmt0) 'q10_mr = ',q10_mr | |||
| write(fates_log(),fmt0) 'q10_froz = ',q10_froz | |||
| write(fates_log(),fmt0) 'cg_strikes = ',cg_strikes | |||
| write(fates_log(),'(a,L)') 'active_crown_fire = ',active_crown_fire | |||
| write(fates_log(),'(a,L2)') 'active_crown_fire = ',active_crown_fire | |||
There was a problem hiding this comment.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/main/EDParamsMod.F90", line 570.31: 1512-047 (E) The L FORMAT edit descriptor, in literal FMT specifier, is missing a field width. A default value based on the edit descriptor and
the type of the data item being processed is assumed.
Comment on lines
-3623
to
+3625
| cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter)) | ||
| cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter,r8)) | ||
| ! Save the number of sub-steps we ultimately used | ||
| cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps)) | ||
| cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps,r8)) |
There was a problem hiding this comment.
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesPlantHydraulicsMod.F90", line 3623.53: 1513-041 (S) Arguments of the wrong type were specified for the INTRINSIC procedure "max".
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesPlantHydraulicsMod.F90", line 3625.53: 1513-041 (S) Arguments of the wrong type were specified for the INTRINSIC procedure "max".
"/autofs/nccs-svm1_home1/azamat/repos/E3SM-tests/components/clm/src/external_models/fates/biogeophys/FatesPlantHydraulicsMod.F90", line 4986.54: 1513-041 (S) Arguments of the wrong type were specified for the INTRINSIC procedure "max".
|
Hi @amametjanov can you make public the location of the test results for us to check please? |
amametjanov
commented
Jun 19, 2020
| type(ed_site_type), intent(in), target :: currentSite | ||
| type(ed_site_type), intent(inout), target :: currentSite |
There was a problem hiding this comment.
PGI compiler warning
PGF90-W-0194-INTENT(IN) argument cannot be defined - currentsite (/qfs/people/mame117/repos/E3SM-tests/components/clm/src/external_models/fates/biogeochem/EDPatchDynamicsMod.F90: 1054)
|
Hi @glemieux, thanks for taking a look.
and the path is
and the path is It's probably easier to try building the cases though. If there are issues with that, please let me know if I should copy build logs somewhere. |
|
Thanks for this submission @amametjanov . These changes all look good to me. |
rgknox
approved these changes
Jun 21, 2020
|
Need help with this warning: Would going from This came up with |
|
@amametjanov , we have another PR addressing this issue: #665 |
|
@amametjanov we were also wondering if we should leave this PR open for a little while if you want to add to it, or is this ready for integration and testing? |
|
This is ready to go. Thanks. |
|
Confirmed SMS_Ld1.ne30_oECv3.F20TRC5-CMIP6.cori-knl_intel test passed b4b: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup compiler warnings and errors that occur with FATES in E3SM.
[BFB] -- bit-for-bit