Merge pull request #666 from amametjanov/azamat/e3sm/cleanup-cpr-warn…

…ings

Cleanup compiler warnings and errors

biogeochem/EDPatchDynamicsMod.F90

@@ -1058,7 +1058,7 @@ subroutine check_patch_area( currentSite )
     ! !USES:
     !
     ! !ARGUMENTS:
-    type(ed_site_type), intent(in), target  :: currentSite 
+    type(ed_site_type), intent(inout), target  :: currentSite
     !
     ! !LOCAL VARIABLES:
     real(r8)                     :: areatot

biogeophys/FatesHydroWTFMod.F90

@@ -210,6 +210,7 @@ function th_from_psi_base(this,psi) result(th)
     class(wrf_type)     :: this
     real(r8),intent(in) :: psi
     real(r8)            :: th
+    th = 0._r8
     write(fates_log(),*) 'The base water retention function'
     write(fates_log(),*) 'should never be actualized'
     write(fates_log(),*) 'check how the class pointer was setup'
@@ -219,6 +220,7 @@ function psi_from_th_base(this,th) result(psi)
     class(wrf_type)     :: this
     real(r8),intent(in) :: th
     real(r8)            :: psi
+    psi = 0._r8
     write(fates_log(),*) 'The base water retention function'
     write(fates_log(),*) 'should never be actualized'
     write(fates_log(),*) 'check how the class pointer was setup'
@@ -228,6 +230,7 @@ function dpsidth_from_th_base(this,th) result(dpsidth)
     class(wrf_type)     :: this
     real(r8),intent(in) :: th
     real(r8)            :: dpsidth
+    dpsidth = 0._r8
     write(fates_log(),*) 'The base water retention function'
     write(fates_log(),*) 'should never be actualized'
     write(fates_log(),*) 'check how the class pointer was setup'
@@ -237,6 +240,7 @@ function ftc_from_psi_base(this,psi) result(ftc)
     class(wkf_type)     :: this
     real(r8),intent(in) :: psi
     real(r8)            :: ftc
+    ftc = 0._r8
     write(fates_log(),*) 'The base water retention function'
     write(fates_log(),*) 'should never be actualized'
     write(fates_log(),*) 'check how the class pointer was setup'
@@ -246,6 +250,7 @@ function dftcdpsi_from_psi_base(this,psi) result(dftcdpsi)
     class(wkf_type)     :: this
     real(r8),intent(in) :: psi
     real(r8)            :: dftcdpsi
+    dftcdpsi = 0._r8
     write(fates_log(),*) 'The base water retention function'
     write(fates_log(),*) 'should never be actualized'
     write(fates_log(),*) 'check how the class pointer was setup'

biogeophys/FatesPlantHydraulicsMod.F90

@@ -3604,9 +3604,9 @@ subroutine ImTaylorSolve1D(site_hydr,cohort,cohort_hydr,dtime,q_top, &
         end if
 
         ! Save the number of times we refined our sub-step counts (iterh1)
-        cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter))
+        cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter,r8))
         ! Save the number of sub-steps we ultimately used
-        cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps))
+        cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps,r8))
 
         ! Update water contents in the relevant plant compartments [m3/m3]
         ! -------------------------------------------------------------------------------
@@ -4967,7 +4967,7 @@ subroutine MatSolve2D(site_hydr,cohort,cohort_hydr, &
          cohort_hydr%iterh1 = cohort_hydr%iterh1 + 1
 
          ! Save the  max number of Newton iterations needed
-         cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nwtn_iter))
+         cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nwtn_iter,r8))
 
          print*,'Completed a newton solve'
          print*,psi_node(:)

main/EDParamsMod.F90

@@ -570,7 +570,7 @@ subroutine FatesReportParams(is_master)
         write(fates_log(),fmt0) 'q10_mr = ',q10_mr
         write(fates_log(),fmt0) 'q10_froz = ',q10_froz
         write(fates_log(),fmt0) 'cg_strikes = ',cg_strikes
-        write(fates_log(),'(a,L)') 'active_crown_fire = ',active_crown_fire
+        write(fates_log(),'(a,L2)') 'active_crown_fire = ',active_crown_fire
         write(fates_log(),*) '------------------------------------------------------'
 
      end if

parteh/PRTGenericMod.F90

@@ -1205,6 +1205,7 @@ function GetCoordVal(this, organ_id, element_id ) result(prt_val)
       integer,intent(in)                :: element_id
       real(r8)                          :: prt_val 
 
+      prt_val = 0._r8
       write(fates_log(),*)'Init must be extended by a child class.'
       call endrun(msg=errMsg(sourcefile, __LINE__))