-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup compiler warnings and errors #666
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,6 +210,7 @@ function th_from_psi_base(this,psi) result(th) | |
class(wrf_type) :: this | ||
real(r8),intent(in) :: psi | ||
real(r8) :: th | ||
th = 0._r8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just to avoid IBM compiler warning with
|
||
write(fates_log(),*) 'The base water retention function' | ||
write(fates_log(),*) 'should never be actualized' | ||
write(fates_log(),*) 'check how the class pointer was setup' | ||
|
@@ -219,6 +220,7 @@ function psi_from_th_base(this,th) result(psi) | |
class(wrf_type) :: this | ||
real(r8),intent(in) :: th | ||
real(r8) :: psi | ||
psi = 0._r8 | ||
write(fates_log(),*) 'The base water retention function' | ||
write(fates_log(),*) 'should never be actualized' | ||
write(fates_log(),*) 'check how the class pointer was setup' | ||
|
@@ -228,6 +230,7 @@ function dpsidth_from_th_base(this,th) result(dpsidth) | |
class(wrf_type) :: this | ||
real(r8),intent(in) :: th | ||
real(r8) :: dpsidth | ||
dpsidth = 0._r8 | ||
write(fates_log(),*) 'The base water retention function' | ||
write(fates_log(),*) 'should never be actualized' | ||
write(fates_log(),*) 'check how the class pointer was setup' | ||
|
@@ -237,6 +240,7 @@ function ftc_from_psi_base(this,psi) result(ftc) | |
class(wkf_type) :: this | ||
real(r8),intent(in) :: psi | ||
real(r8) :: ftc | ||
ftc = 0._r8 | ||
write(fates_log(),*) 'The base water retention function' | ||
write(fates_log(),*) 'should never be actualized' | ||
write(fates_log(),*) 'check how the class pointer was setup' | ||
|
@@ -246,6 +250,7 @@ function dftcdpsi_from_psi_base(this,psi) result(dftcdpsi) | |
class(wkf_type) :: this | ||
real(r8),intent(in) :: psi | ||
real(r8) :: dftcdpsi | ||
dftcdpsi = 0._r8 | ||
write(fates_log(),*) 'The base water retention function' | ||
write(fates_log(),*) 'should never be actualized' | ||
write(fates_log(),*) 'check how the class pointer was setup' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3620,9 +3620,9 @@ subroutine ImTaylorSolve1D(site_hydr,cohort,cohort_hydr,dtime,q_top, & | |
end if | ||
|
||
! Save the number of times we refined our sub-step counts (iterh1) | ||
cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter)) | ||
cohort_hydr%iterh1 = max(cohort_hydr%iterh1,real(iter,r8)) | ||
! Save the number of sub-steps we ultimately used | ||
cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps)) | ||
cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nsteps,r8)) | ||
Comment on lines
-3623
to
+3625
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
! Update water contents in the relevant plant compartments [m3/m3] | ||
! ------------------------------------------------------------------------------- | ||
|
@@ -4983,7 +4983,7 @@ subroutine MatSolve2D(site_hydr,cohort,cohort_hydr, & | |
cohort_hydr%iterh1 = cohort_hydr%iterh1 + 1 | ||
|
||
! Save the max number of Newton iterations needed | ||
cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nwtn_iter)) | ||
cohort_hydr%iterh2 = max(cohort_hydr%iterh2,real(nwtn_iter,r8)) | ||
|
||
print*,'Completed a newton solve' | ||
print*,psi_node(:) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -567,7 +567,7 @@ subroutine FatesReportParams(is_master) | |
write(fates_log(),fmt0) 'q10_mr = ',q10_mr | ||
write(fates_log(),fmt0) 'q10_froz = ',q10_froz | ||
write(fates_log(),fmt0) 'cg_strikes = ',cg_strikes | ||
write(fates_log(),'(a,L)') 'active_crown_fire = ',active_crown_fire | ||
write(fates_log(),'(a,L2)') 'active_crown_fire = ',active_crown_fire | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
write(fates_log(),*) '------------------------------------------------------' | ||
|
||
end if | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PGI compiler warning