Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct API endpoint for project approvers #489

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Correct API endpoint for project approvers #489

merged 1 commit into from
Mar 1, 2019

Conversation

jasonwbarnett
Copy link
Contributor

Updating the approvers API endpoint to align with the gitlab docs:

Reference: https://docs.gitlab.com/ee/api/merge_request_approvals.html#change-allowed-approvers

@jasonwbarnett
Copy link
Contributor Author

@NARKOZ Let me know if there is anything else I can do.

@connorshea
Copy link
Contributor

I guess #454 wasn't comprehensive enough? Why not also change the project_merge_request_approvals method?

@jasonwbarnett
Copy link
Contributor Author

jasonwbarnett commented Feb 28, 2019 •
edited
Loading

#project_merge_request_approvals is already correct. I'm guessing the miss on #edit_project_merge_request_approvals was just an oversight.

@NARKOZ NARKOZ merged commit 5c61984 into NARKOZ:master Mar 1, 2019
@JianweiWangs JianweiWangs mentioned this pull request Mar 1, 2019
Closed
@jasonwbarnett jasonwbarnett deleted the bugfix/merge_request_approvals branch March 1, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NARKOZ NARKOZ NARKOZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonwbarnett @connorshea @NARKOZ