Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab.edit_project_approvers 404 Not Found #491

Closed
JianweiWangs opened this issue Mar 1, 2019 · 1 comment
Closed

Gitlab.edit_project_approvers 404 Not Found #491

JianweiWangs opened this issue Mar 1, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@JianweiWangs
Copy link

# Change allowed approvers and approver groups for a project
    #
    # @example
    #    Gitlab.edit_project_approvers(1, {approver_ids: [5], approver_groups: [1]})
    #
    # @param [Integer] project(required) The ID of a project.
    # @option options [Array] :approver_ids(optional) An array of User IDs that can approve MRs
    # @option options [Array] :approver_group_ids(optional) An array of Group IDs whose members can approve MRs
    # @return [Gitlab::ObjectifiedHash] MR approval configuration information about the project
    def edit_project_approvers(project, options = {})
      put("/projects/#{url_encode project}/approvals", body: options)
    end

approvals is typo, from Merge request approvals API, it should be approvers, I will fix it soon

@NARKOZ NARKOZ added the bug Something isn't working label Mar 1, 2019
@JianweiWangs
Copy link
Author

#489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants