refactor(model): add ReleaseMetadata container #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estamp, changelog)
…acy Jenkins adapter
skaldarnar
changed the title
skaldarnar
added
Topic: Tests/QA
jdrueckert
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The determination whether we are starting a LWJGL v2 or v3 game in
ApplicationControllerfails with aNumberFormatExceptionas the version string of the game release is no longer a plain build number. Therefore, the comment in https://github.com/MovingBlocks/TerasologyLauncher/blob/master/src/main/java/org/terasology/launcher/ui/ApplicationController.java#L341-L352 became more important.I've decided to move this flag to the
GameRelease, and implement the determination in the repository adapters (I think this works until we have better identifiers/versions for the game packages itself).(The new logic is not used yet, but only activated in #628. In hindsight, I should have done only the refactoring first, then added the determination logic plus tests, and only then switch to the new code...)