fix(controller): prevent NumberFormatException on starting game #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estamp, changelog)
…acy Jenkins adapter
…ata from selected release on starting game
skaldarnar
changed the title
skaldarnar
changed the title
skaldarnar
added
the
Type: Bug
jdrueckert
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #627 the determination for whether we are starting a LWJGL v2 or v3 game fails for games downloaded from the "new" Jenkins (http://jenkins.terasology.io).
With this fix the
ApplicationControllerrelies on the determination as done by the repository adapters and does not attempt to parse the version string on its own.