Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throttle chunk processing based on deadline #5238

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

BenjaminAmos
Copy link
Contributor

Contains

This pull request attempts to reduce the effects of long chunk processing times by spreading it out over several frames. If a processing deadline is exceeded (currently 24ms) then LocalChunkProvider should stop processing and resume on the next tick.

Ideally LocalChunkProvider::tick should take that long to execute, however, this reduces the severity of such occurences as an interim solution.

How to test

  • Start a new game
  • In the first few minutes of gameplay you should see some warnings referring to chunk processing taking too long.

@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Apr 22, 2024
@soloturn soloturn merged commit 1c52f5e into develop Apr 26, 2024
15 checks passed
@BenjaminAmos BenjaminAmos deleted the feature/throttle-chunk-processing branch June 23, 2024 13:32
@skaldarnar skaldarnar added this to the 2023 Revive - Milestone 3 milestone Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants