prepare subprojects.settings.gradle for kotlin #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminAmos
reviewed
Jan 2, 2024
libs/subprojects.settings.gradle
Outdated
| } | ||
| logger.info("lib {} has a build file so counting it complete and including it.", subprojectName) | ||
| include(subprojectName) |
There was a problem hiding this comment.
You've changed this from using includeBuild to include. Is this likely to have implications? An includeBuild is usually used for separate third-party projects, whilst include is typically used for projects within your own tree.
There was a problem hiding this comment.
fixed, @BenjaminAmos,
soloturn
force-pushed
the
qa/subproj-kotlin
branch
2 times, most recently
from
488493c
to
fe4bc96
Compare
BenjaminAmos
previously requested changes
Jan 3, 2024
Co-authored-by: BenjaminAmos <24301287+BenjaminAmos@users.noreply.github.com>
soloturn
force-pushed
the
qa/subproj-kotlin
branch
from
fe4bc96
to
7c8a202
Compare
BenjaminAmos
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the files similar in logic, as well use syntax a little closer to kotlin, to then mirgrate and have a clearer, easier to review diff vew.